Form autofill popup should appear under the focused field

[bbondy]

Instead it is currently showing up in the middle for me. For @darkdh it appears at the correct location though. Maybe a DPI issue?

[luixxiul]

Same here on Windows 7 64 bit

[darkdh]

That's weird. My location is correct

[bsclifton]

I tested this too (after running rm -rf ./node_modules/ && rm -rf ~/.electron/ && npm install) and it looks good to me (macOS):

Let me try on Windows

[bsclifton]

doh- it happened for me on Windows 😦

[bsclifton]

@darkdh mentioned position is emitted from here:
https://github.com/brave/electron/blob/master/atom/browser/autofill/atom_autofill_client.cc#L166

I can help look at this issue

[bsclifton]

@bbondy did you have any specific STR? I can't repro on Mac

[bsclifton]

I'm reliably able to repro now- thanks to @bridiver for suggestion when I was talking it out

Offset appears to be adding the offset of the window in addition to the frame's x/y. Looking at a fix now...

[bsclifton]

PRs submitted for brave/electron and brave/browser-laptop

Root cause:

• position being sent back was the top left of the textbox
• need to add the height of the textbox, so it goes below
• @darkdh had the right idea by getting the client area;
  • however, we didn't want the X/Y... we needed the width/height
  • this can be compared against the frame's width/height
  • offset is then correct

[luixxiul]

On 0.11.6 Beta5 (Windows 7 64 bit JP)

Hasn't this been fixed?

[luixxiul]

Also, though I click the suggestion, it is not filled in the field.

[darkdh]

This is brave built-in password manager, I assume.

[luixxiul]

Yes it is. I just thought they were similar.

[bridiver]

autofill seems to track usernames as well, but the location is correct on mac