Brave Payments : First time user wallet creation : If a user attempts to change the value before the wallet is created, Brave will crash.

[alexwykoff]

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
If a user is starting for the first time and attempt to change the monthly allowance while their wallet is being created, Brave will crash.

Expected behavior:
Brave should not crash and the selected value should be respected.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Tested on Win7 x64
• Brave Version:
  0.12.3 RC5
• Steps to reproduce:
  1. With a clean install, go to the Payments preference pane, enable payments.
  2. While the wallet is being created, select another value from the 'Monthly budget' dropdown.
• Screenshot if needed:
• Any related issues:

[alexwykoff]

I'll be the first to admit, this is an edge case and the user has to know what they're doing and be moving fast for it to occur.

cc @mrose17 @diracdeltas

[alexwykoff]

Here is the dump when launched from command line in Ubuntu:

test@test:~$ brave
could not parse data:  undefined
An uncaught exception occurred in the main process Uncaught Exception:
Error: Ledger client initialization incomplete.
    at Client.getBraveryProperties (/usr/share/brave/resources/app.asar/node_modules/ledger-client/index.js:115:19)
    at setPaymentInfo (/usr/share/brave/resources/app.asar/app/ledger.js:1250:24)
    at doAction (/usr/share/brave/resources/app.asar/app/ledger.js:137:11)
    at /usr/share/brave/resources/app.asar/js/dispatcher/appDispatcher.js:67:23
    at Array.forEach (native)
    at AppDispatcher.dispatch (/usr/share/brave/resources/app.asar/js/dispatcher/appDispatcher.js:64:20)
    at EventEmitter.ipcMain.on (/usr/share/brave/resources/app.asar/js/dispatcher/appDispatcher.js:129:21)
    at emitTwo (events.js:106:13)
    at EventEmitter.emit (events.js:191:7)
    at WebContents.<anonymous> (/usr/share/brave/resources/electron.asar/browser/api/web-contents.js:210:13)
/usr/share/brave/resources/app.asar/node_modules/node-anonize2-relic-emscripten/anonize2.js:18
if(!Module)Module=(typeof Module!=="undefined"?Module:null)||{};var moduleOverrides={};for(var key in Module){if(Module.hasOwnProperty(key)){moduleOverrides[key]=Module[key]}}var ENVIRONMENT_IS_WEB=false;var ENVIRONMENT_IS_WORKER=false;var ENVIRONMENT_IS_NODE=false;var ENVIRONMENT_IS_SHELL=false;if(Module["ENVIRONMENT"]){if(Module["ENVIRONMENT"]==="WEB"){ENVIRONMENT_IS_WEB=true}else if(Module["ENVIRONMENT"]==="WORKER"){ENVIRONMENT_IS_WORKER=true}else if(Module["ENVIRONMENT"]==="NODE"){ENVIRONMENT_IS_NODE=true}else if(Module["ENVIRONMENT"]==="SHELL"){ENVIRONMENT_IS_SHELL=true}else{throw new Error("The provided Module['ENVIRONMENT'] value is not valid. It must be one of: WEB|WORKER|NODE|SHELL.")}}else{ENVIRONMENT_IS_WEB=typeof window==="object";ENVIRONMENT_IS_WORKER=typeof importScripts==="function";ENVIRONMENT_IS_NODE=typeof process==="object"&&typeof require==="function"&&!ENVIRONMENT_IS_WEB&&!ENVIRONMENT_IS_WORKE

Error: Ledger client initialization incomplete.
    at Client.getBraveryProperties (/usr/share/brave/resources/app.asar/node_modules/ledger-client/index.js:115:19)
    at setPaymentInfo (/usr/share/brave/resources/app.asar/app/ledger.js:1250:24)
    at doAction (/usr/share/brave/resources/app.asar/app/ledger.js:137:11)
    at /usr/share/brave/resources/app.asar/js/dispatcher/appDispatcher.js:67:23
    at Array.forEach (native)
    at AppDispatcher.dispatch (/usr/share/brave/resources/app.asar/js/dispatcher/appDispatcher.js:64:20)
    at EventEmitter.ipcMain.on (/usr/share/brave/resources/app.asar/js/dispatcher/appDispatcher.js:129:21)
    at emitTwo (events.js:106:13)
    at EventEmitter.emit (events.js:191:7)
    at WebContents.<anonymous> (/usr/share/brave/resources/electron.asar/browser/api/web-contents.js:210:13)