long hang on Firefox import #4879

asadotzler · 2016-10-18T00:49:06Z

Did you search for similar issues before submitting this one? Yes

Describe the issue you encountered: Importing Firefox data (history, bookmarks, and cookies) hung the Brave app for a good 30 seconds. Windows reported Brave as "(Not Responding)" for the duration.

Expected behavior: Brave shouldn't hang. Also a progress indicator of some sort would be helpful if it's gonna take that long.

Platform (Win7, 8, 10? macOS? Linux distro?): Win10
Brave Version: 0.12.4
Steps to reproduce:
1. visit settings and import all types data from Firefox
2. notice brave become unresponsive
3. check task manager and see Not Responding for about 30 seconds
Screenshot if needed:
Any related issues: why no import passwords?

Test Plan:

Performance:

Import bulk bookmarks (4000+) from other browsers (Don't merge into
toolbar)
The process should finish instantly
Delete Import from XXX folder
The process should finish instantly

Migration:

Make sure session-store-1 contains the sites data before 0.12.10
Lauch Brave and Close
sites of session-store-1 should change from [] tp {}

bbondy · 2016-10-18T02:40:07Z

/cc @darkdh

polarity · 2016-10-20T09:27:15Z

I have the same issue on OS X 10.10.5 with Brave 0.12.5. Brave hangs on Firefox import, never finishes and i have to kill the instance. Also nothing happened after reopening brave.

bbondy · 2016-10-22T13:11:54Z

@darkdh could we perhaps do things more async so it doesn't seem like a hang and maybe add a font-awesome animation like:

<i class="fa fa-spinner fa-spin fa-3x fa-fw"></i>
<span class="sr-only">Loading...</span>

jkup · 2016-10-27T23:33:52Z

I have a support ticket where a user (Win10 x64) has waited 30+ minutes without import finishing. Is this likely the same problem or something different?

darkdh · 2016-10-28T00:28:10Z

@jkup , did user import from firefox? and what option did user choose? (history/bookmarks/cookies )

jkup · 2016-10-28T01:19:42Z

Yes and bookmarks

bbondy · 2016-10-28T15:12:33Z

I can repro too w/ firefox imports but not chrome imports.

alexwykoff · 2016-10-31T20:38:08Z

I've repro'd with Chrome and large exported bookmarks files as well. There is no system status on import progress.

@bbondy

fix #4879 Auditors: @bbondy, @bsclifton, @cezaraugusto Test Plan: 1. Import bulk bookmarks (4000+) from other browsers 2. The process should finish instantly

@bbondy

fix #4879 Auditors: @bbondy, @bsclifton, @cezaraugusto Test Plan: Performance: 1. Import bulk bookmarks (4000+) from other browsers (Don't merge into toolbar) 2. The process should finish instantly 3. Delete Import from XXX folder 4. The process should finish instantly Migration: 1. Make sure session-store-1 contains the sites data before 0.12.10 2. Lauch Brave and Close 3. sites of session-store-1 should change from [] tp {}

jaredbeck · 2016-11-10T16:16:01Z

I encountered this issue on my first day of trying Brave. (Became unresponsive [beachball] and had to force quit.) Switching browsers without importing bookmarks and cookies is too big of a hurdle, so this is a blocker for me using Brave at all. Though negative, I hope this feedback is helpful! I'll try Brave in a few more months when it's more mature. Keep up the good work.

@bbondy

* Change sites from List to Map fix #4879 Auditors: @bbondy, @bsclifton, @cezaraugusto Test Plan: Performance: 1. Import bulk bookmarks (4000+) from other browsers (Don't merge into toolbar) 2. The process should finish instantly 3. Delete Import from XXX folder 4. The process should finish instantly Migration: 1. Make sure session-store-1 contains the sites data before 0.12.10 2. Lauch Brave and Close 3. sites of session-store-1 should change from [] tp {} * Address @bsclifton's feedback * Apply changes to aboutNewTabState * - Added migration for newtab data (and tested manually several times) - Updated tests to be using/expecting a map (not a list) - Updated siteUtil to return empty map where appropriate (instead of empty array) - Removed unused method in siteUtil - Extra error handling in siteUtil.updateSiteFavicon - Added back some of the missing tests for updateSiteFavicon - Update newtab > getUnpinned() to use slice (since it's a map) Auditors: @darkdh, @cezaraugusto * removed tags (not needed)

bbondy · 2016-11-12T03:14:12Z

Reverted due to automated test problems, and some other problems described in the PR that was reverted.

@bbondy

fix #4879 Auditors: @bbondy, @bsclifton, @cezaraugusto Test Plan: Performance: 1. Import bulk bookmarks (4000+) from other browsers (Don't merge into toolbar) 2. The process should finish instantly 3. Delete Import from XXX folder 4. The process should finish instantly Migration: 1. Make sure session-store-1 contains the sites data before 0.12.10 2. Lauch Brave and Close 3. sites of session-store-1 should change from [] tp {}

@bbondy

fix #4879 Auditors: @bbondy, @bsclifton, @cezaraugusto Test Plan: Performance: 1. Import bulk bookmarks (4000+) from other browsers (Don't merge into toolbar) 2. The process should finish instantly 3. Delete Import from XXX folder 4. The process should finish instantly Migration: 1. Make sure session-store-1 contains the sites data before 0.12.10 2. Lauch Brave and Close 3. sites of session-store-1 should change from [] tp {}

@bbondy

fix #4879 Auditors: @bbondy, @bsclifton, @cezaraugusto Test Plan: Performance: 1. Import bulk bookmarks (4000+) from other browsers (Don't merge into toolbar) 2. The process should finish instantly 3. Delete Import from XXX folder 4. The process should finish instantly Migration: 1. Make sure session-store-1 contains the sites data before 0.12.10 2. Lauch Brave and Close 3. sites of session-store-1 should change from [] tp {}

@bbondy

fix #4879 Auditors: @bbondy, @bsclifton, @cezaraugusto Test Plan: Performance: 1. Import bulk bookmarks (4000+) from other browsers (Don't merge into toolbar) 2. The process should finish instantly 3. Delete Import from XXX folder 4. The process should finish instantly Migration: 1. Make sure session-store-1 contains the sites data before 0.12.10 2. Lauch Brave and Close 3. sites of session-store-1 should change from [] tp {}

@bbondy

fix #4879 Auditors: @bbondy, @bsclifton, @cezaraugusto Test Plan: Performance: 1. Import bulk bookmarks (4000+) from other browsers (Don't merge into toolbar) 2. The process should finish instantly 3. Delete Import from XXX folder 4. The process should finish instantly Migration: 1. Make sure session-store-1 contains the sites data before 0.12.10 2. Lauch Brave and Close 3. sites of session-store-1 should change from [] tp {}

@bbondy

fix #4879 Auditors: @bbondy, @bsclifton, @cezaraugusto Test Plan: Performance: 1. Import bulk bookmarks (4000+) from other browsers (Don't merge into toolbar) 2. The process should finish instantly 3. Delete Import from XXX folder 4. The process should finish instantly Migration: 1. Make sure session-store-1 contains the sites data before 0.12.10 2. Lauch Brave and Close 3. sites of session-store-1 should change from [] tp {}

@bbondy

fix #4879 Auditors: @bbondy, @bsclifton, @cezaraugusto Test Plan: Performance: 1. Import bulk bookmarks (4000+) from other browsers (Don't merge into toolbar) 2. The process should finish instantly 3. Delete Import from XXX folder 4. The process should finish instantly Migration: 1. Make sure session-store-1 contains the sites data before 0.12.10 2. Lauch Brave and Close 3. sites of session-store-1 should change from [] tp {}

@bbondy

fix #4879 Auditors: @bbondy, @bsclifton, @cezaraugusto Test Plan: Performance: 1. Import bulk bookmarks (4000+) from other browsers (Don't merge into toolbar) 2. The process should finish instantly 3. Delete Import from XXX folder 4. The process should finish instantly Migration: 1. Make sure session-store-1 contains the sites data before 0.12.10 2. Lauch Brave and Close 3. sites of session-store-1 should change from [] tp {}

@bbondy

fix #4879 Auditors: @bbondy, @bsclifton, @cezaraugusto Test Plan: Performance: 1. Import bulk bookmarks (4000+) from other browsers (Don't merge into toolbar) 2. The process should finish instantly 3. Delete Import from XXX folder 4. The process should finish instantly Migration: 1. Make sure session-store-1 contains the sites data before 0.12.10 2. Lauch Brave and Close 3. sites of session-store-1 should change from [] tp {}

@bbondy

fix #4879 Auditors: @bbondy, @bsclifton, @cezaraugusto Test Plan: Performance: 1. Import bulk bookmarks (4000+) from other browsers (Don't merge into toolbar) 2. The process should finish instantly 3. Delete Import from XXX folder 4. The process should finish instantly Migration: 1. Make sure session-store-1 contains the sites data before 0.12.10 2. Lauch Brave and Close 3. sites of session-store-1 should change from [] tp {}

@bbondy

fix #4879 Auditors: @bbondy, @bsclifton, @cezaraugusto Test Plan: Performance: 1. Import bulk bookmarks (4000+) from other browsers (Don't merge into toolbar) 2. The process should finish instantly 3. Delete Import from XXX folder 4. The process should finish instantly Migration: 1. Make sure session-store-1 contains the sites data before 0.12.10 2. Lauch Brave and Close 3. sites of session-store-1 should change from [] tp {}

nik9t · 2017-01-18T10:21:21Z

same issue - Brave hangs on import of Firefox data - only option being to force quit. 3 attempts and sadly have to walk away from Brave until there is a solution to this problem

luixxiul · 2017-01-18T10:27:23Z

@nik9t it'll be solved in 0.13.1

nik9t · 2017-01-18T11:58:39Z

Thanks so much for letting me know - looking forward to that release!

…

On 18 Jan 2017, at 10:27 am, Suguru Hirahara ***@***.***> wrote: @nik9t <https://github.com/nik9t> it'll be solved in 0.13.1 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4879 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AYB8C466iHY722mFOUm9PVkI0NEqNL1jks5rTekPgaJpZM4KZQwo>.

@bbondy

fix #4879 Auditors: @bbondy, @bsclifton, @cezaraugusto Test Plan: Performance: 1. Import bulk bookmarks (4000+) from other browsers (Don't merge into toolbar) 2. The process should finish instantly 3. Delete Import from XXX folder 4. The process should finish instantly Migration: 1. Make sure session-store-1 contains the sites data before 0.12.10 2. Lauch Brave and Close 3. sites of session-store-1 should change from [] tp {}

@darkdh

When old site didn't exist it would error early and not import anything on the undefined.get() access. Related to #4879 Auditors: @darkdh

luixxiul added the feature/importer label Oct 18, 2016

bbondy added this to the 0.12.8dev milestone Oct 22, 2016

darkdh self-assigned this Oct 22, 2016

darkdh modified the milestones: 0.12.9dev, 0.12.8dev Oct 31, 2016

darkdh modified the milestones: 0.12.10 release , 0.12.9dev Nov 8, 2016

darkdh added a commit that referenced this issue Nov 10, 2016

Change sites from List to Map

b5349f6

fix #4879 Auditors: @bbondy, @bsclifton, @cezaraugusto Test Plan: 1. Import bulk bookmarks (4000+) from other browsers 2. The process should finish instantly

darkdh mentioned this issue Nov 10, 2016

Change sites from List to Map #5531

Merged

4 tasks

cezaraugusto closed this as completed in #5531 Nov 11, 2016

bbondy reopened this Nov 12, 2016

darkdh mentioned this issue Nov 14, 2016

Change sites from List to Map #5587

Merged

4 tasks

bbondy modified the milestones: 0.12.11, 0.12.10 release , 1.0.0, 0.13.2 Nov 15, 2016

darkdh modified the milestones: 0.13.1, 0.13.2 Dec 15, 2016

bbondy closed this as completed in #5587 Jan 28, 2017

luixxiul added QA/test-plan-specified release-notes/include labels Jan 28, 2017

bbondy added a commit that referenced this issue Jan 29, 2017

Fix importing bookmarks not importing anything

048c617

When old site didn't exist it would error early and not import anything on the undefined.get() access. Related to #4879 Auditors: @darkdh

This was referenced Feb 3, 2017

Manual Tests for Windows x64 0.13.2 RC2 #7030

Closed

Manual Tests for Windows ia-32 0.13.2 RC3 #7029

Closed

Manual Tests for Linux 0.13.2 RC3 #7028

Closed

Manual Tests for OS X 0.13.2 RC2 #7027

Closed

bbondy added the QA/checked-macOS label Feb 3, 2017

aekeus added the QA/checked-Linux label Feb 4, 2017

luixxiul added the QA/checked-Win32 label Feb 4, 2017

luixxiul mentioned this issue Feb 4, 2017

Selecting subfolders on the bookmark bar which have many entries can be quite laggy #7053

Closed

srirambv added the QA/checked-Win64 label Feb 6, 2017

MartenKahr mentioned this issue Mar 10, 2017

Brave hangs, eventually crashes, when importing Firefox browsing history #7646

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

long hang on Firefox import #4879

long hang on Firefox import #4879

asadotzler commented Oct 18, 2016 •

edited by luixxiul

Loading

bbondy commented Oct 18, 2016

polarity commented Oct 20, 2016

bbondy commented Oct 22, 2016

jkup commented Oct 27, 2016

darkdh commented Oct 28, 2016

jkup commented Oct 28, 2016

bbondy commented Oct 28, 2016

alexwykoff commented Oct 31, 2016

jaredbeck commented Nov 10, 2016

bbondy commented Nov 12, 2016

nik9t commented Jan 18, 2017

luixxiul commented Jan 18, 2017

nik9t commented Jan 18, 2017 via email

long hang on Firefox import #4879

long hang on Firefox import #4879

Comments

asadotzler commented Oct 18, 2016 • edited by luixxiul Loading

Test Plan:

bbondy commented Oct 18, 2016

polarity commented Oct 20, 2016

bbondy commented Oct 22, 2016

jkup commented Oct 27, 2016

darkdh commented Oct 28, 2016

jkup commented Oct 28, 2016

bbondy commented Oct 28, 2016

alexwykoff commented Oct 31, 2016

jaredbeck commented Nov 10, 2016

bbondy commented Nov 12, 2016

nik9t commented Jan 18, 2017

luixxiul commented Jan 18, 2017

nik9t commented Jan 18, 2017 via email

asadotzler commented Oct 18, 2016 •

edited by luixxiul

Loading