Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

regression: drag area above URL bar was reduced to 2px #5225

Closed
bradleyrichter opened this issue Oct 28, 2016 · 3 comments · Fixed by #5240
Closed

regression: drag area above URL bar was reduced to 2px #5225

bradleyrichter opened this issue Oct 28, 2016 · 3 comments · Fixed by #5240
Assignees
@bsclifton
Labels
bug feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 regression
Milestone
0.12.8dev

Comments

@bradleyrichter
Copy link
Contributor

Did you search for similar issues before submitting this one?
no

Describe the issue you encountered:
Regression on available drag area at top of address bar.

Expected behavior:
Top 6 pixels should be available for dragging window. Now, back to only 2px.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    mac OS Sierra 10.12
  • Brave Version:
    0.12.7dev-RC2
  • Steps to reproduce:
    1. try to drag in normal area
    2. notice available height is now very limited (and remember fixing this yourself months ago)
  • Screenshot if needed:
    address bar dragging regression
@bradleyrichter bradleyrichter added this to the 0.12.7dev milestone Oct 28, 2016
@bradleyrichter bradleyrichter changed the title regression: drag area above URL bar is reduced to 2px regression: drag area above URL bar was reduced to 2px Oct 28, 2016
@privatzee
Copy link
Contributor

related: #5168

@bbondy bbondy modified the milestones: 0.12.8dev, 0.12.7dev Oct 28, 2016
@bbondy
Copy link
Member

bbondy commented Oct 28, 2016

@bsclifton seems maybe related to titlebar work

@bsclifton
Copy link
Member

bsclifton commented Oct 28, 2016 •
edited
Loading

Caused by this: #5070

Although somewhat similar, it's NOT the cause of #5168

This was referenced Oct 28, 2016
Merged
Closed
This was referenced Nov 2, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
bug feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 regression
Projects
None yet
Milestone
0.12.8dev
Development

Successfully merging a pull request may close this issue.

Fix regression caused by removing drag from URL bar element
7 participants
@bbondy @alexwykoff @luixxiul @bsclifton @bradleyrichter @srirambv @privatzee