Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Removed draggable style from URL bar (was causing maximize w/ double … #5070

Merged
merged 1 commit into from
Oct 24, 2016
Merged

Removed draggable style from URL bar (was causing maximize w/ double … #5070

merged 1 commit into from
Oct 24, 2016

Conversation

bsclifton
Copy link
Member

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Removed draggable style from URL bar (was causing maximize w/ double click on Windows)

Fixes #4922

Auditors: @bbondy

Test plan:

  1. Launch Brave on Windows and double click inside URL bar (ex: to left of
    lock icon or on the time loaded)
  2. Window should no longer maximize.
  3. Lock icon is still drag/droppable onto bookmarks toolbar, etc.

…click on Windows)

Fixes #4922

Auditors: @bbondy

Test plan:
1. Launch Brave on Windows and double click inside URL bar (ex: to left of
lock icon or on the time loaded)
2. Window should no longer maximize.
3. Lock icon is still drag/droppable onto bookmarks toolbar, etc.
@bsclifton bsclifton added this to the 0.12.7dev milestone Oct 23, 2016
@bbondy
Copy link
Member

bbondy commented Oct 24, 2016

++ thanks

@bbondy bbondy merged commit c56727b into brave:master Oct 24, 2016
@bsclifton bsclifton deleted the url-bar-double-click branch October 24, 2016 23:39
@luixxiul luixxiul modified the milestones: 0.12.6dev, 0.12.7dev Oct 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants