Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Provide Password Manager/Extension icon in right click context menu #5292

Closed
srirambv opened this issue Oct 31, 2016 · 2 comments · Fixed by #5350
Closed

Provide Password Manager/Extension icon in right click context menu #5292

srirambv opened this issue Oct 31, 2016 · 2 comments · Fixed by #5350
Assignees
@darkdh
Labels
feature/extensions feature/password-manager QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.9dev

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
No icon shown for password manager/extensions in right click context menu

Expected behavior:
Provide Password Manager/Extension icon in right click context menu

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version:
    0.12.8 Preview 1

  • Screenshot if needed:
    image

  • Any related issues:
@srirambv srirambv added this to the 0.12.9dev milestone Oct 31, 2016
@darkdh darkdh self-assigned this Nov 2, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Nov 2, 2016
@darkdh
Set extension icon in context menu
661f0f4 
requires brave/muon#86
fix brave#5292

Auditors: @bridiver, @bbondy

Test Plan:
1. Enable pocket
2. right click to popup context menu
3. Save to pocket should have icon
@darkdh darkdh mentioned this issue Nov 2, 2016
Merged
4 tasks
@bbondy bbondy modified the milestones: 0.12.10 release , 0.12.9dev Nov 9, 2016
@bbondy
Copy link
Member

bbondy commented Nov 9, 2016

We aren't getting a new electron for this release so moving it to 0.12.10, sorry about that.

@bbondy bbondy modified the milestones: 0.12.9dev, 0.12.10 release Nov 9, 2016
@bbondy
Copy link
Member

bbondy commented Nov 9, 2016

We ended up doing 1.4.24 for a security issue so I included this in 0.12.9 after all.

This was referenced Nov 10, 2016
Closed
Closed
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Nov 14, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/extensions feature/password-manager QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.9dev
Development

Successfully merging a pull request may close this issue.

Set extension icon in context menu darkdh/browser-laptop
5 participants
@bbondy @alexwykoff @luixxiul @darkdh @srirambv