Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

clicking entries on about:history is laggy #5382

Closed
luixxiul opened this issue Nov 4, 2016 · 5 comments · Fixed by #5600
Closed

clicking entries on about:history is laggy #5382

luixxiul opened this issue Nov 4, 2016 · 5 comments · Fixed by #5600
Assignees
@NejcZdovc
Labels
feature/history perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Nov 4, 2016 •
edited
Loading

Test plan

#10136 (comment)

Describe the issue you encountered: clicking entries on about:history is laggy. You have to wait ~0.5s until the entry you click is actually selected.

Expected behavior: it should be selected instantly

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS

  • Brave Version: master branch

  • Steps to reproduce:

    1. Open about:history
    2. Click an entry
    3. Wait ~0.5s until the entry is selected

  • Any related issues:
@luixxiul luixxiul added this to the 0.12.9dev milestone Nov 4, 2016
@luixxiul
Copy link
Contributor Author

luixxiul commented Nov 4, 2016

cc @bsclifton

@bsclifton
Copy link
Member

yikes- this one is pretty bad. I'm not exactly sure what we can do yet, but I'll bump back to 0.12.10 for now

@bsclifton bsclifton modified the milestones: 0.12.10 release , 0.12.9dev Nov 8, 2016
@bsclifton bsclifton self-assigned this Nov 11, 2016
This was referenced Nov 11, 2016
Closed
Merged
@luixxiul
Copy link
Contributor Author

@bsclifton I cannot feel the difference and it is still laggy for me. Would you please check it out?

@luixxiul luixxiul reopened this Nov 16, 2016
@bsclifton
Copy link
Member

bsclifton commented Nov 17, 2016 •
edited
Loading

removing milestone...

@bsclifton bsclifton removed this from the 0.12.10 release milestone Nov 17, 2016
@bsclifton bsclifton removed their assignment Dec 6, 2016
@bsclifton bsclifton added this to the contributor backlog milestone Dec 6, 2016
@luixxiul luixxiul removed this from the contributor backlog milestone Apr 30, 2017
@NejcZdovc NejcZdovc mentioned this issue Jul 20, 2017
Closed
8 tasks
@luixxiul luixxiul added this to the 0.20.x (Developer Channel) milestone Jul 20, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Jul 20, 2017 •
edited by NejcZdovc
Loading

Adding the same milestone as #10136, which would possibly fix this issue.

@NejcZdovc NejcZdovc self-assigned this Jul 26, 2017
@NejcZdovc NejcZdovc mentioned this issue Jul 26, 2017
Merged
8 tasks
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Nightly Channel), 0.20.x (Developer Channel) Aug 4, 2017
NejcZdovc added a commit that referenced this issue Aug 4, 2017
@NejcZdovc
Splits sites object in the app state
c2fd650 
Resolves #1646
Resolves #1856
Resolves #2655
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5072
Resolves #5699
Resolves #5382
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@NejcZdovc @dfperry5
Splits sites object in the app state
33861b7 
Resolves brave#1646
Resolves brave#1856
Resolves brave#2655
Resolves brave#2771
Resolves brave#3646
Resolves brave#3694
Resolves brave#4224
Resolves brave#4260
Resolves brave#4833
Resolves brave#4868
Resolves brave#4929
Resolves brave#5072
Resolves brave#5699
Resolves brave#5382
Resolves brave#6104
Resolves brave#6108
Resolves brave#6585
Resolves brave#8022
Resolves brave#9301
Resolves brave#9326
Resolves brave#9978
Resolves brave#10026

Auditors:

Test Plan:
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
This was referenced Dec 27, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/history perf QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

History fixes and misc about page fixes
History fixes and misc about page fixes
6 participants
@bbondy @luixxiul @bsclifton @NejcZdovc @srirambv @LaurenWags