Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

extend blue outline in URL bar to include bookmark button #5439

Closed
bradleyrichter opened this issue Nov 6, 2016 · 10 comments
Closed

extend blue outline in URL bar to include bookmark button #5439

bradleyrichter opened this issue Nov 6, 2016 · 10 comments
Labels
design A design change, especially one which needs input from the design team. feature/URLbar stale

Comments

@bradleyrichter
Copy link
Contributor

old:

image

new:
image

@bradleyrichter bradleyrichter added design A design change, especially one which needs input from the design team. feature/URLbar labels Nov 6, 2016
@bradleyrichter bradleyrichter added this to the 0.12.9dev milestone Nov 6, 2016
@pouyakary
Copy link

@bradleyrichter thanks a lot! This is way much better.

@bbondy
Copy link
Member

bbondy commented Nov 23, 2016

I had to revert this because of a couple of big UI bugs that were introduced.

Reverted here:
9aedf58

Screenshot of UI bugs:

screenshot 2016-11-23 18 17 01

screenshot 2016-11-23 18 24 39

@bradleyrichter
Copy link
Contributor Author

@jkup I was trying to fix a few things in it but ran into the search-favicon problem and thought it was too risky for the next freeze..

@jkup
Copy link
Contributor

jkup commented Nov 24, 2016

@bradleyrichter @bbondy what is the bug in the first image? what is the search-favicon problem?

@luixxiul
Copy link
Contributor

See #5816

@bsclifton bsclifton modified the milestones: 0.13.1, 0.13.0 Nov 24, 2016
@bsclifton
Copy link
Member

Bumped to 0.13.1

@jkup
Copy link
Contributor

jkup commented Dec 14, 2016

Closed my PR against this and going to wait until @bsclifton merges in the new PNG sprite version of the icons!

@luixxiul luixxiul removed this from the 0.13.1 milestone Jan 18, 2017
@bradleyrichter
Copy link
Contributor Author

@cezaraugusto @jamesmudgett this has been sitting but what do you 2 think? Still looks better than current? (see above)

@cezaraugusto
Copy link
Contributor

changes looks better than current imo

@luixxiul
Copy link
Contributor

luixxiul commented Apr 7, 2017

the current has changed thanks to @NejcZdovc fyi

#8059

@cezaraugusto cezaraugusto self-assigned this Jul 3, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@cezaraugusto cezaraugusto removed their assignment Jul 30, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/URLbar stale
Projects
None yet
Development

No branches or pull requests

7 participants