Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Too much spacing between Home button and URL bar on Master #5816

Closed
srirambv opened this issue Nov 23, 2016 · 4 comments
Closed

Too much spacing between Home button and URL bar on Master #5816

srirambv opened this issue Nov 23, 2016 · 4 comments
Labels
design A design change, especially one which needs input from the design team. feature/URLbar

Comments

@srirambv
Copy link
Collaborator

srirambv commented Nov 23, 2016

Did you search for similar issues before submitting this one?

Describe the issue you encountered:
Too much spacing between Home button and URL bar on Master

Expected behavior:
Should not have too much spacing between home button and URL bar

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version:
    master

  • Steps to reproduce:

    1. Enable Home button in preferences, see the spacing between URL bar and home button
    2. Reduce the size of the window horizontally, spacing remains as it is but URL right border is messed up right border gets tucked in the URL bar
  • Screenshot if needed:
    image

image

@srirambv srirambv added design A design change, especially one which needs input from the design team. feature/URLbar OS/Windows release/blocking labels Nov 23, 2016
@srirambv srirambv added this to the 0.13.0 milestone Nov 23, 2016
@luixxiul
Copy link
Contributor

This is caused by moving the star icon (.bookmarkButton) in .startButtons which is outside of .urlbarForm into it with CSS. We could set width:0 to .startButtons but it would lead unexpected regressions.

@bradleyrichter
Copy link
Contributor

I'm fixing this one.

@bsclifton
Copy link
Member

With the rollback of the blue outline PR (with 9aedf58), this should be resolved, right?

@bradleyrichter
Copy link
Contributor

yes

@bsclifton bsclifton removed this from the 0.13.0 milestone Nov 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/URLbar
Projects
None yet
Development

No branches or pull requests

4 participants