Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Ledger notifications for adding funds should only be shown if brave payments is switched on #5441

Closed
bbondy opened this issue Nov 7, 2016 · 6 comments
Closed

Ledger notifications for adding funds should only be shown if brave payments is switched on #5441

bbondy opened this issue Nov 7, 2016 · 6 comments
Assignees
@mrose17
Labels
feature/rewards QA/test-plan-specified release-notes/include
Milestone
0.13.0

Comments

@bbondy
Copy link
Member

bbondy commented Nov 7, 2016 •
edited
Loading

I noticed it said it was time to add funds but I did not have Brave Payments enabled.
@bbondy bbondy added this to the 0.12.9dev milestone Nov 7, 2016
@bbondy
Copy link
Member Author

bbondy commented Nov 7, 2016

See also:
#5418

@ayumi
Copy link
Contributor

ayumi commented Nov 7, 2016

I'm not able to reproduce.

Steps I tried:

  1. Fresh browser profile / user data
  2. Turn on Payments, wait for wallet create to finish.
  3. Turn off Payments.
  4. Close browser
  5. Update ledger-state.json reconcileStamp and bootStamp to in the past
  6. Reopen browser

Can you provide repro steps?

@ayumi ayumi self-assigned this Nov 8, 2016
@brave-office brave-office modified the milestones: 0.12.11, 0.12.9dev Nov 8, 2016
@mrose17
Copy link
Member

mrose17 commented Nov 17, 2016

@bbondy - i can't reproduce this either. i found one small bit of code that was logically correct -- but redundant -- which i simplified.

can you reproduce it on the current master? thanks!

mrose17 added a commit that referenced this issue Nov 17, 2016
@mrose17
do not count a transaction-in-progress as a transaction...
9653daf 
Fixes #5371

Fixes #5441 (i can’t
reproduce it — neither could @ayumi — but i cleaned up a little bit of
logic to make it easier to follow.
@mrose17 mrose17 mentioned this issue Nov 17, 2016
Merged
@mrose17 mrose17 assigned mrose17 and unassigned ayumi Nov 17, 2016
@bbondy
Copy link
Member Author

bbondy commented Nov 22, 2016

I don't know how to reproduce, my wife just got the notification on her computer, and I checked preferences and the Payments master switch was turned off. There have been fixes since then though, not sure if it would be fixed now or not.

@bbondy bbondy modified the milestones: Backlog, 0.13.0 Nov 22, 2016
@bbondy
Copy link
Member Author

bbondy commented Nov 22, 2016

moved to backlog until someone has steps. Feel free to close if you think it's fixed by something else.

@cndouglas cndouglas modified the milestones: 0.13.0, Backlog Dec 3, 2016
This was referenced Dec 12, 2016
Closed
Closed
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
Closed
@luixxiul
Copy link
Contributor

Test plan: #5721

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrose17 mrose17

Labels
feature/rewards QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
6 participants
@mrose17 @ayumi @bbondy @luixxiul @cndouglas @brave-office