-
Notifications
You must be signed in to change notification settings - Fork 973
add windows specific font CSS for URL text and tab text #5624
Comments
@bradleyrichter +1 from support on Windows fonts being blurry compared to Chrome |
@srirambv See: #6149 /cc: @bradleyrichter |
Test planmake sure that UI looks like the mockup image above #5624 (comment) |
The 1st line needs to be It is needed by this line https://github.com/brave/browser-laptop/blame/2a78248d7b3e8611d251c2ef697f309f26d3a7c3/less/navigationBar.less#L813 of my commit: 19360c1
|
I reopened for the next milestone 0.13.1 |
By setting However, by replacing the margin property with Because fa-lock and fa-unlock icon is also aligned at the center of If you remove margin-left on 0.12.15, you get: On the other hand, on 0.13.0 RC4 with the modification, you would get: So I think we just need to set @bradleyrichter wdyt? |
@luixxiul looks good! |
@bradleyrichter OK I'll create a PR later .. |
@bsclifton would you mind taking the tab font issue? browser-laptop/js/components/tab.js Lines 158 to 167 in 4a907a8
|
The remainder of the work has already been completed by @cezaraugusto (great job!) 🎉 The weight, pulling styles into Aphrodite, and more was done with https://github.com/brave/browser-laptop/pull/6900/files#diff-400b4094e3a5aaea84160dcc1483b3c2R250 And then the font size was addressed for all OSes with #7316 |
Test plan:
#7316 (comment)
URL bar
I found some changes needed to improve legibility and sync the styles between mac and windows.
With the changes below, we will have a match between OSs in the URL and Tab text.
(note: these are for WINDOWS CSS only)
URL
update: this was fixed with #6848
tab font
The text was updated successfully, but these errors were encountered: