Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Load time shown in URL bar needs left padding when URL is selected #5814

Closed
srirambv opened this issue Nov 23, 2016 · 2 comments
Closed

Load time shown in URL bar needs left padding when URL is selected #5814

srirambv opened this issue Nov 23, 2016 · 2 comments
Labels
design A design change, especially one which needs input from the design team. feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.2

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Page load time shown in URL bar needs left padding when URL is selected.

Expected behavior:
Should retain the left padding when the URL text is selected

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version:
    master

  • Steps to reproduce:

    1. Open any site wait till the full page is loaded
    2. Page load time has padding when URL text is not selected
    3. On URL selection the padding is lost and the time shown is right next to the last character selected in the URL

  • Screenshot if needed:
    image
    image

  • Any related issues:
    cc: @bradleyrichter @bsclifton
@srirambv srirambv added design A design change, especially one which needs input from the design team. feature/URLbar labels Nov 23, 2016
@gyandeeps gyandeeps mentioned this issue Dec 21, 2016
Merged
4 tasks
cezaraugusto pushed a commit that referenced this issue Jan 18, 2017
@gyandeeps @cezaraugusto
Fix: Add right margin when url bar is in focus (fixes #5814) (#6358)
9ae2c06
bsclifton pushed a commit that referenced this issue Jan 18, 2017
@gyandeeps @bsclifton
Fix: Add right margin when url bar is in focus (fixes #5814) (#6358)
a266979
bsclifton pushed a commit that referenced this issue Jan 18, 2017
@gyandeeps @bsclifton
Fix: Add right margin when url bar is in focus (fixes #5814) (#6358)
6647bee
NejcZdovc pushed a commit to NejcZdovc/browser-laptop that referenced this issue Jan 23, 2017
@gyandeeps @NejcZdovc
Fix: Add right margin when url bar is in focus (fixes brave#5814) (br…
f5ebce8 
…ave#6358)
bsclifton pushed a commit that referenced this issue Jan 23, 2017
@gyandeeps @bsclifton
Fix: Add right margin when url bar is in focus (fixes #5814) (#6358)
bc33c80
bsclifton pushed a commit that referenced this issue Jan 24, 2017
@gyandeeps @bsclifton
Fix: Add right margin when url bar is in focus (fixes #5814) (#6358)
024db1a
bsclifton pushed a commit that referenced this issue Jan 25, 2017
@gyandeeps @bsclifton
Fix: Add right margin when url bar is in focus (fixes #5814) (#6358)
cd1c07c
bsclifton pushed a commit that referenced this issue Jan 25, 2017
@gyandeeps @bsclifton
Fix: Add right margin when url bar is in focus (fixes #5814) (#6358)
9ab9307
@bbondy bbondy closed this as completed in 02f1329 Jan 26, 2017
@luixxiul
Copy link
Contributor

Will this be included in 0.13.0 or 0.13.1?

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Jan 26, 2017
@bbondy
Copy link
Member

bbondy commented Jan 27, 2017

Sorry @luixxiul there were 2 invalid RC tags made from master and not dev-channel, I removed them. So the commit now shows the correct info. It is not in 0.13.0.

@bbondy bbondy added this to the 0.13.1 milestone Jan 27, 2017
@luixxiul luixxiul removed the needs-info Another team member needs information from the PR/issue opener. label Jan 27, 2017
This was referenced Feb 3, 2017
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
design A design change, especially one which needs input from the design team. feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.2
Development

No branches or pull requests
4 participants
@aekeus @bbondy @luixxiul @srirambv