Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactoring #bitcoinDashboard dialog on about:preferences#payments (l10n) #6007

Closed
luixxiul opened this issue Dec 3, 2016 · 3 comments
Closed

Refactoring #bitcoinDashboard dialog on about:preferences#payments (l10n) #6007

luixxiul opened this issue Dec 3, 2016 · 3 comments
Assignees
@luixxiul
Labels
feature/rewards l10n misc/button QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified refactoring release-notes/include
Milestone
0.13.0

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Dec 3, 2016 •
edited
Loading

Describe the issue you encountered:

  • border-bottom on the bottom should not exist ("Done" button is not displayed if Coinbase is disabled)
  • padding & margin should be refactored

screenshot 2016-12-03 20 53 59

Expected behavior:

The footer should be displayed.

screenshot 2016-12-15 23 45 57

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS

  • Brave Version: master branch

  • Any related issues:
This was referenced Dec 3, 2016
Closed
Merged
@bsclifton bsclifton added this to the 0.13.0 milestone Dec 6, 2016
@luixxiul
Copy link
Contributor Author

luixxiul commented Dec 15, 2016 •
edited
Loading

Reopening this as 21ece29 is refactored with #6047 which has a follow-up. Will be closed with the PR.

@luixxiul luixxiul reopened this Dec 15, 2016
@bsclifton
Copy link
Member

Closing because #6047 was just merged 😄

This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Dec 20, 2016
Closed
@luixxiul
Copy link
Contributor Author

luixxiul commented Jan 16, 2017 •
edited
Loading

Test Plan:

  1. Change your lang setting on Brave
  2. Disable Coinbase widget
  3. Make sure every button on the dialog on about:preferences#payments works

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/rewards l10n misc/button QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified refactoring release-notes/include
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
3 participants
@luixxiul @bsclifton @srirambv