Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactoring dialog on about:preferences#payments (l10n) #6008

Closed
wants to merge 1 commit into from
Closed

Refactoring dialog on about:preferences#payments (l10n) #6008

wants to merge 1 commit into from

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Dec 3, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Closes #6007

border-bottom on the bottom should not exist (the button is not displayed if Coinbase is enabled)

Auditors: @bbondy @bradleyrichter

Test Plan:

  1. Disable Coinbase widget
  2. Make sure every button on the dialog on about:preferences#payments works

Closes #6007

border-bottom on the bottom should not exist (the button is not displayed if Coinbase is enabled)

Auditors: @bbondy

Test Plan:
1. Disable Coinbase widget
2. Make sure every button on the dialog on about:preferences#payments works
@luixxiul
Copy link
Contributor Author

luixxiul commented Dec 4, 2016

Closing in favor of #6009

the commit was cherry-picked

@luixxiul luixxiul closed this Dec 4, 2016
@luixxiul luixxiul removed this from the 0.13.0 milestone Dec 4, 2016
@luixxiul luixxiul deleted the refactoring-paymentBoard branch December 5, 2016 03:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant