Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

about:extension doesn't contain Favicons of any of the installed extensions #6257

Closed
srirambv opened this issue Dec 16, 2016 · 3 comments
Closed

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
about:extension doesn't contain Favicons of any of the installed extensions

Expected behavior:
Should show the favicons for installed extensions

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version:
    0.13.0 Preview 4

  • Steps to reproduce:

    1. Enable all extensions on 0.13.0
    2. Open about:extensions, none of them have the favicons
  • Screenshot if needed:
    image

  • Any related issues:

@cezaraugusto
Copy link
Contributor

This is related to how we collect icon files, which ideally we should collect via chrome-extension:// instead of file://. #6290 didn't address the issue the right way.

Stepping back in favor of @bbondy comment. Will happily assist anything needed.

@cezaraugusto cezaraugusto removed their assignment Dec 19, 2016
@bbondy
Copy link
Member

bbondy commented Dec 19, 2016

So I tried a lot of different things, Chrome encodes to data:// urls, which we could calculate on extension load. We might possibly be able to get to it via chrome extension management api once we implement as well. For now I ended up just going to simply adding file://* without removing the others.

@luixxiul
Copy link
Contributor

Test plan:

Open about:extensions
Make sure that extensions have their icons

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants