Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Wallet Recovery success dialog should close parent dialog when hitting OK #6263

Closed
bradleyrichter opened this issue Dec 16, 2016 · 4 comments
Closed

Wallet Recovery success dialog should close parent dialog when hitting OK #6263

bradleyrichter opened this issue Dec 16, 2016 · 4 comments
Assignees
@willy-b
Labels
feature/rewards QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-required release-notes/include
Milestone
0.13.2

Comments

@bradleyrichter
Copy link
Contributor

image

Currently, it closes the overlay and leaves the user with ackward button choices.

image
@bradleyrichter bradleyrichter added this to the 1.0.0 milestone Dec 16, 2016
@willy-b
Copy link
Contributor

willy-b commented Dec 16, 2016 •
edited
Loading

Hey @bradleyrichter, this is already implemented as part of PR #5809 .

@willy-b
Copy link
Contributor

willy-b commented Dec 16, 2016

We could also grab just the fix for this specifically without the rest of that PR by cherry-picking commit e01ad04

@bradleyrichter
Copy link
Contributor Author

cool! I will leave that up to @bsclifton . I can wait if needed.

@willy-b willy-b mentioned this issue Dec 21, 2016
Merged
4 tasks
@bsclifton bsclifton assigned willy-b and unassigned bsclifton Jan 9, 2017
@bsclifton bsclifton modified the milestones: 0.13.1, 1.0.0 Jan 9, 2017
cezaraugusto pushed a commit that referenced this issue Jan 9, 2017
@cezaraugusto
Add "Import recovery keys" button to Payments->Advanced->Recover
3b6cbb9 
(opens a file chooser dialog)

fixes #4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes #6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
@bsclifton
Copy link
Member

Fixed with #5809 which was merged into branch 0.13.1-branch.

bsclifton pushed a commit that referenced this issue Jan 14, 2017
@bsclifton
Add "Import recovery keys" button to Payments->Advanced->Recover
5721182 
(opens a file chooser dialog)

fixes #4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes #6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
bsclifton pushed a commit that referenced this issue Jan 17, 2017
@bsclifton
Add "Import recovery keys" button to Payments->Advanced->Recover
073d0e2 
(opens a file chooser dialog)

fixes #4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes #6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
bsclifton pushed a commit that referenced this issue Jan 17, 2017
@bsclifton
Add "Import recovery keys" button to Payments->Advanced->Recover
af9d4f3 
(opens a file chooser dialog)

fixes #4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes #6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
bsclifton pushed a commit that referenced this issue Jan 18, 2017
@bsclifton
Add "Import recovery keys" button to Payments->Advanced->Recover
a861abd 
(opens a file chooser dialog)

fixes #4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes #6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
bsclifton pushed a commit that referenced this issue Jan 20, 2017
@bsclifton
Add "Import recovery keys" button to Payments->Advanced->Recover
55ccacd 
(opens a file chooser dialog)

fixes #4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes #6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
NejcZdovc pushed a commit to NejcZdovc/browser-laptop that referenced this issue Jan 23, 2017
@NejcZdovc
Add "Import recovery keys" button to Payments->Advanced->Recover
a3f5955 
(opens a file chooser dialog)

fixes brave#4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes brave#6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
bsclifton pushed a commit that referenced this issue Jan 23, 2017
@bsclifton
Add "Import recovery keys" button to Payments->Advanced->Recover
69040ce 
(opens a file chooser dialog)

fixes #4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes #6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
bsclifton pushed a commit that referenced this issue Jan 24, 2017
@bsclifton
Add "Import recovery keys" button to Payments->Advanced->Recover
30ace6c 
(opens a file chooser dialog)

fixes #4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes #6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
bsclifton pushed a commit that referenced this issue Jan 25, 2017
@bsclifton
Add "Import recovery keys" button to Payments->Advanced->Recover
0c8ff37 
(opens a file chooser dialog)

fixes #4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes #6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
bsclifton pushed a commit that referenced this issue Jan 25, 2017
@bsclifton
Add "Import recovery keys" button to Payments->Advanced->Recover
7bffa13 
(opens a file chooser dialog)

fixes #4806

Includes tests for Ledger backup and recovery:
- add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js`
- add tests for backup and recovery of wallet
- add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`)
  client.translations: returns a map of all existing translations (current locale) to test client

Import recovery keys success closes modals
- successful import closes modals
- and closing file chooser dialog does not trigger error screen

fixes #6263

Import recovery keys shows error popover if keys are invalid or missing
- error popover is displayed if paymentId / passphrase are missing or not UUIDs
  (ledger-client#recoverWallet should probably do validation too)
- added tests for cases:
  one or both recovery keys missing from file
  a recovery key is not a UUID
  an empty recovery file
This was referenced Feb 3, 2017
Closed
Closed
Closed
@srirambv srirambv mentioned this issue Feb 3, 2017
Closed
86 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@willy-b willy-b

Labels
feature/rewards QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-required release-notes/include
Projects
None yet
Milestone
0.13.2
Development

No branches or pull requests
5 participants
@alexwykoff @luixxiul @bsclifton @willy-b @bradleyrichter