Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

URL bar context menu shows Paste Without Formatting #6268

Closed
srirambv opened this issue Dec 16, 2016 · 4 comments
Closed

URL bar context menu shows Paste Without Formatting #6268

srirambv opened this issue Dec 16, 2016 · 4 comments
Assignees

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?

Describe the issue you encountered:
URL bar context menu shows Paste Without Formatting

Expected behavior:
Paste without formatting should not be shown in right click context menu in URL bar

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version:
    0.13.0 Preview 4

  • Steps to reproduce:

    1. Right click on the URL bar to bring up the context menu
    2. Shows Paste Without Formatting
    3. If it is to be shown then Without to be changed to without to keep in line with Paste and Search
  • Screenshot if needed:
    Brave/Opera/Chrome/Firefox
    image

  • Any related issues:

@srirambv srirambv added this to the 0.13.0 milestone Dec 16, 2016
@cezaraugusto cezaraugusto self-assigned this Dec 17, 2016
@bbondy
Copy link
Member

bbondy commented Dec 19, 2016

@srirambv was this present in 0.12?

@cndouglas
Copy link

This is caused by my PR #6126 (commit 433e3c9). If you want, we could just revert/move the commit to 0.13.1 (which it was originally assigned for).

@bsclifton
Copy link
Member

@liunkae thanks for helping identify the issue 😄 I think that's a reasonable approach; I'll go ahead and revert it and re-open the original issue

You can then submit another PR which further restricts where this menu item should be shown. I believe it should only be shown for input fields inside the content area

@bsclifton
Copy link
Member

PR #6126 has been reverted and issue #5822 is reopened and ready for you to check out again (for 0.13.1 timeframe), @liunkae 😄

I'll go ahead and close this issue; I manually verified it's no longer showing up after the revert

@bsclifton bsclifton removed this from the 0.13.0 milestone Dec 19, 2016
cezaraugusto pushed a commit that referenced this issue Dec 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants