Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed options on about:preferences#payments to allow for localization #6364

Closed
luixxiul opened this issue Dec 21, 2016 · 3 comments
Closed

Fixed options on about:preferences#payments to allow for localization #6364

luixxiul opened this issue Dec 21, 2016 · 3 comments
Assignees
@NejcZdovc
Labels
copy/content/text feature/rewards l10n QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.14.0

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Dec 21, 2016 •
edited
Loading

Test plan

  1. Change your lang setting to a foreign language
  2. Open about:preferences#payments
  3. Click "Advanced Settings..."

Describe the issue you encountered:

#6309 (comment)

I confirmed "5seconds" and "8views" on Brave payments 的高級設置 were not localizable. the others are just missing localized strings.

In Japanese,

clipboard01
@luixxiul luixxiul modified the milestone: 0.13.1 Dec 21, 2016
@luixxiul luixxiul added this to the contributor backlog milestone Dec 23, 2016
@bsclifton
Copy link
Member

@luixxiul shared a commit in another issue which shows an elegant way to do this with variables:
https://github.com/luixxiul/browser-laptop/commit/ef284caa8be29a62ea18f68cc38f8f7c4d0244fa

This approach should work great here too 😄 Removing ledger label and adding content

@luixxiul luixxiul mentioned this issue Mar 8, 2017
Merged
4 tasks
@NejcZdovc NejcZdovc modified the milestones: 0.13.6, contributor backlog Mar 8, 2017
@NejcZdovc NejcZdovc self-assigned this Mar 8, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 8, 2017
@NejcZdovc
Refactor of paymentTab
cd1d842 
Resolves brave#7501 brave#7380 brave#6364

Auditors: @bsclifton @cezaraugusto

Test plan:
- everything should work the same as was before the chage

Refactor of disabled content
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 11, 2017
@NejcZdovc
Refactor of paymentTab
f375451 
Resolves brave#7501 brave#7380 brave#6364

Auditors: @bsclifton @cezaraugusto

Test plan:
- everything should work the same as was before the chage

Refactor of disabled content
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 12, 2017
@NejcZdovc
Refactor of paymentTab
405efe5 
Resolves brave#7501 brave#7380 brave#6364

Auditors: @bsclifton @cezaraugusto

Test plan:
- everything should work the same as was before the chage
cezaraugusto pushed a commit that referenced this issue Mar 12, 2017
@NejcZdovc @cezaraugusto
Refactor of paymentTab (#7481)
0bfceeb 
Resolves #7501 #7380 #6364

Auditors: @bsclifton @cezaraugusto

Test plan:
- everything should work the same as was before the chage
@luixxiul
Copy link
Contributor Author

Closed with #7481

This was referenced Mar 14, 2017
Closed
Closed
Closed
Closed
Closed
@luixxiul
Copy link
Contributor Author

Confirmed on Transifex too.

This was referenced Mar 17, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Mar 21, 2017
Closed
@alexwykoff alexwykoff changed the title Options in the select elements on about:preferences#payments should be localizable Fixed options on about:preferences#payments to allow for localization Mar 28, 2017
This was referenced Mar 28, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
copy/content/text feature/rewards l10n QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
5 participants
@alexwykoff @luixxiul @bsclifton @NejcZdovc @srirambv