Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Icons in about:extensions may not be 48x48 #6580

Closed
jonathansampson opened this issue Jan 8, 2017 · 2 comments
Closed

Icons in about:extensions may not be 48x48 #6580

jonathansampson opened this issue Jan 8, 2017 · 2 comments
Assignees
@jonathansampson
Labels
design A design change, especially one which needs input from the design team. feature/extensions QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.2

Comments

@jonathansampson
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
The about:extensions page assumes images are the size they claim to be in their extension manifest file. This is not the case with all extensions (confirmed by a recent extension I was porting).

Expected behavior:
The about:extensions page displays extension icons as 48 pixels wide.

Brave Version (revision SHA): 0.12.15
@jonathansampson jonathansampson added design A design change, especially one which needs input from the design team. feature/extensions labels Jan 8, 2017
@jonathansampson jonathansampson added this to the 0.13.1 milestone Jan 8, 2017
@jonathansampson jonathansampson self-assigned this Jan 8, 2017
@jonathansampson jonathansampson mentioned this issue Jan 8, 2017
Merged
4 tasks
@bsclifton
Copy link
Member

Fixed with #6581 which was merged into branch 0.13.1-branch.

This was referenced Feb 3, 2017
Closed
Closed
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Feb 6, 2017

Test Plan

Enable all extension from settings
Visit about:extension
Open developer tools and verify the image loaded is 48x48 images

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jonathansampson jonathansampson

Labels
design A design change, especially one which needs input from the design team. feature/extensions QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.2
Development

No branches or pull requests
5 participants
@jonathansampson @alexwykoff @luixxiul @bsclifton @srirambv