Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Uncaught TypeError: Cannot read property 'length' of undefined(…) contextMenus.js:946 in about:extension page #7092

Closed
srirambv opened this issue Feb 6, 2017 · 2 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Feb 6, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    While testing Icons in about:extensions may not be 48x48 #6580 , right click on the extensions entry in about:extension shows

    Uncaught TypeError: Cannot read property 'length' of undefined(…) contextMenus.js:946

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.13.2
    rev 726b9d2

  • Steps to reproduce:

    1. Do a clean install of 0.13.2 RC6
    2. Open about:extension page and open browser console
    3. Right click on the extensions entry, console shows error
  • Actual result:
    Right click on the extensions entry, console shows error

  • Expected result:
    Should not show error

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes. Verified in 0.13.1

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    consoleerror

  • Any related issues:
    Uncaught TypeError: cannot read property 'has' of undefined(...) : onKeyDown @ menubar.js:160 #7055

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 6, 2017

@srirambv I have a solution for it, but I am not sure what should be a result of a contextMenu. What items should be show?

Right now is something like this (after a fix), in which I don't see any real value.
image

@srirambv
Copy link
Collaborator Author

srirambv commented Feb 6, 2017

I don't think it needs to show context menu. We are not allowing users to open the installed folder location or do anything else. I think disabling right click on that page should be fine. @bbondy thoughts?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants