Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

GitHub crashes the tab process #6656

Closed
jonathansampson opened this issue Jan 16, 2017 · 2 comments · Fixed by brave/muon#146
Closed

GitHub crashes the tab process #6656

jonathansampson opened this issue Jan 16, 2017 · 2 comments · Fixed by brave/muon#146
Assignees
@darkdh
Labels
bug crash QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.13.0

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Jan 16, 2017 •
edited by luixxiul
Loading

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Some pages appear to crash the browser tab process. Some do this immediately, others do it after some time. For instance, I repro this on github.com, but only after switching back to Brave after some time.

Expected behavior:
Tab processes should not crash for common/popular sites.

Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10

Brave Version (revision SHA): 0.13.0 Preview 8

Steps to reproduce:

  1. Navigate to Clicking on Pocket widget doesn't launch the pocket login page, Browser restart opens pocket login (intermittent issue)  #6586 (comment)
  2. Switch to another application for 10 minutes
  3. Switch back to Brave and attempt to scroll up/down for a few seconds

Screenshot if needed:

Any related issues: #6557

Test plan

  1. open two tabs of Clicking on Pocket widget doesn't launch the pocket login page, Browser restart opens pocket login (intermittent issue)  #6586 (comment)
  2. keep switching tabs and make scrolling repeatedly
@jonathansampson jonathansampson added this to the 0.13.0 milestone Jan 16, 2017
@darkdh darkdh self-assigned this Jan 16, 2017
@darkdh
Copy link
Member

darkdh commented Jan 16, 2017

quick way to reproduce:

  1. open two tabs of Clicking on Pocket widget doesn't launch the pocket login page, Browser restart opens pocket login (intermittent issue)  #6586 (comment)
  2. keep switching tabs and make scrolling repeatedly

@darkdh
Copy link
Member

darkdh commented Jan 17, 2017 •
edited
Loading

This is huge amount of memory leak on renderer on all platforms and it exceeds the limit so sandbox kill the process with SBOX_FATAL_MEMORY_EXCEEDED (7012)

darkdh added a commit to darkdh/electron that referenced this issue Jan 19, 2017
@darkdh
Cherry-pick "Save a copy when advancing to dependent GIF and WebP ani…
7a32091 
…mation frames"

https://chromium.googlesource.com/chromium/src.git/+/3a38c33c398189620281ad19a0f8e5b7f6ac3e69

must pick these commits in order first and do some proper modification
1. https://chromium.googlesource.com/chromium/src/+/605fa62ea2c9ac2924ff08f21106775d412bed5b
2. https://chromium.googlesource.com/chromium/src/+/3fd7c79eea0cb0f981a73b1264568366214f229e
3. https://chromium.googlesource.com/chromium/src/+/78115b26dfafd0fca676ac33caabd3aa8b43ecf4
4. https://chromium.googlesource.com/chromium/src/+/69969af74bfff920f5fdcc2aa547ea4af2d477d2

should be removed when upgrading to chromium 55

fix brave/browser-laptop#6656

Auditors: @bbondy, @bridiver, @bsclifton
@darkdh darkdh mentioned this issue Jan 19, 2017
Merged
darkdh added a commit to darkdh/electron that referenced this issue Jan 19, 2017
@darkdh
Cherry-pick "Save a copy when advancing to dependent GIF and WebP ani…
663965f 
…mation frames"

https://chromium.googlesource.com/chromium/src.git/+/3a38c33c398189620281ad19a0f8e5b7f6ac3e69

must pick these commits in order first and do some proper modification
1. https://chromium.googlesource.com/chromium/src/+/605fa62ea2c9ac2924ff08f21106775d412bed5b
2. https://chromium.googlesource.com/chromium/src/+/3fd7c79eea0cb0f981a73b1264568366214f229e
3. https://chromium.googlesource.com/chromium/src/+/78115b26dfafd0fca676ac33caabd3aa8b43ecf4
4. https://chromium.googlesource.com/chromium/src/+/69969af74bfff920f5fdcc2aa547ea4af2d477d2

should be removed when upgrading to chromium 55

fix brave/browser-laptop#6656

Auditors: @bbondy, @bridiver, @bsclifton
darkdh added a commit to darkdh/electron that referenced this issue Jan 19, 2017
@darkdh
Cherry-pick "Save a copy when advancing to dependent GIF and WebP ani…
2fc4920 
…mation frames"

https://chromium.googlesource.com/chromium/src.git/+/3a38c33c398189620281ad19a0f8e5b7f6ac3e69

must pick these commits in order first and do some proper modification
1. https://chromium.googlesource.com/chromium/src/+/605fa62ea2c9ac2924ff08f21106775d412bed5b
2. https://chromium.googlesource.com/chromium/src/+/3fd7c79eea0cb0f981a73b1264568366214f229e
3. https://chromium.googlesource.com/chromium/src/+/78115b26dfafd0fca676ac33caabd3aa8b43ecf4
4. https://chromium.googlesource.com/chromium/src/+/69969af74bfff920f5fdcc2aa547ea4af2d477d2

should be removed when upgrading to chromium 55

fix brave/browser-laptop#6656

Auditors: @bbondy, @bridiver, @bsclifton
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
bug crash QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

Cherry-pick "Save a copy when advancing to dependent GIF and WebP animation frames" darkdh/electron
6 participants
@jonathansampson @bbondy @alexwykoff @luixxiul @darkdh @srirambv