Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Replace input and select elements with <FormTextbox> and <FormDropdown> in .bookmarkFormTable #6777

Closed
srirambv opened this issue Jan 20, 2017 · 7 comments · Fixed by #6947
Closed

Comments

@srirambv
Copy link
Collaborator

srirambv commented Jan 20, 2017

Test plan

#8136 (comment)


  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Bookmark hanger items are not properly aligned & text looks blurry

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.13.0
    rev fefd17c

Steps to reproduce:

1. Visit any site
2. Use keyboard shortcut to add bookmark / click on the bookmark button to add
3. The element alignment is off
4. Text on the bookmark mark hanger looks blurry 
  • Actual result:
    Drop down list is left aligned with the title whereas Title & location text and input element is not aligned with the heading. Text on the bookmark hanger looks blurry with system DPI set at 125%

  • Expected result:
    All elements should be properly aligned and text on the bookmark hanger should not look blurry

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    image

    Text compared to the tab looks blurry
    image

  • Any related issues:

Test plan

#6947 (comment)

@srirambv srirambv added feature/bookmarks polish Nice to have — usually related to front-end/visual tasks. QA/test-plan-specified release/not-blocking labels Jan 20, 2017
@srirambv srirambv added this to the 0.13.2 milestone Jan 20, 2017
@luixxiul
Copy link
Contributor

I think this will be fixed with #6689

CC @bsclifton for a comment

@bsclifton
Copy link
Member

@luixxiul that is correct 😄 I also believe this will be fixed when we find the root cause / close out #6462 and #6698

See the image at #6462 (comment) for another example of text going from crisp to blurry

@bsclifton bsclifton self-assigned this Jan 31, 2017
bsclifton added a commit that referenced this issue Jan 31, 2017
…n Windows

This was originally added to fix #4517, #4518, and #4472... but is no longer needed (I confirmed all those situations work).

Fixes #6462
Fixes #6777
Fixes #6144
Fixes #3556
Fixes #2089

Auditors: @bridiver, @bbondy, @darkdh
@bsclifton bsclifton added bug/dpi/monitor and removed polish Nice to have — usually related to front-end/visual tasks. labels Jan 31, 2017
@bsclifton bsclifton modified the milestones: 0.13.2, 0.13.3 Jan 31, 2017
bbondy pushed a commit that referenced this issue Jan 31, 2017
…n Windows

This was originally added to fix #4517, #4518, and #4472... but is no longer needed (I confirmed all those situations work).

Fixes #6462
Fixes #6777
Fixes #6144
Fixes #3556
Fixes #2089

Auditors: @bridiver, @bbondy, @darkdh
@luixxiul
Copy link
Contributor

luixxiul commented Feb 4, 2017

Bookmark hanger items are still not properly aligned.

It seems that #6689 to separate input and select styles using Aphrodite did not include the fix under fd0c10a#diff-57a5fbf005ecc202d1e7e08c11f73b93R58 for the bookmark hanger, which should have been like this (not exactly the same): #6084 (comment)

screenshot 2016-12-12 4 42 55

@luixxiul luixxiul reopened this Feb 4, 2017
@luixxiul luixxiul modified the milestones: 0.13.3, 0.13.2 Feb 4, 2017
@luixxiul luixxiul changed the title Bookmark hanger items are not properly aligned & text looks blurry Bookmark hanger items are not properly aligned Feb 4, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Feb 4, 2017

The issue was reopened and renamed as the text blurry issue was fixed.

@luixxiul luixxiul changed the title Bookmark hanger items are not properly aligned Replace input and select elements with <FormTextbox> and <FormDropdown> in .bookmarkFormTable Feb 4, 2017
@bbondy bbondy modified the milestones: 0.13.5, 0.13.6 Feb 15, 2017
@cndouglas
Copy link

The UI controls in the bookmark popup look very different from the UI controls elsewhere (e.g. preferences):
image
image

@luixxiul
Copy link
Contributor

luixxiul commented Mar 4, 2017

@liunkae I am sorry if it was not obvious but that is actually what I wanted to make clear on #6777 (comment)

@luixxiul
Copy link
Contributor

Fixed with #8443 (#8136)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.