Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tabs display wrong after exiting HTML5 fullscreen #7301

Closed
bbondy opened this issue Feb 17, 2017 · 3 comments · Fixed by #10691
Closed

Tabs display wrong after exiting HTML5 fullscreen #7301

bbondy opened this issue Feb 17, 2017 · 3 comments · Fixed by #10691
Assignees
@cezaraugusto
Labels
bug feature/tabsbar misc/fullscreen-option QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@bbondy
Copy link
Member

bbondy commented Feb 17, 2017 •
edited by luixxiul
Loading

Test plan

#10691 (comment)

My wife found this one...

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    When exiting html5 video full screen, tabs display wrong, see screenshot.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS (probably other OS as well)

  • Brave Version (revision SHA):
    013.4 release

  • Steps to reproduce:

    1. Go to youtube.com and play a video
    2. Click the full screen button
    3. Click escape to exit full screen

  • Actual result:
    All tabs will display wrong with a favicon centered and no text
    After hovering they will display ok again

  • Expected result:
    Tabs should display correctly before and after the full screen event.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes, but the regression was reproduced with last release.

  • Can this issue be consistently reproduced?
    yes

  • Screenshot if needed:

screenshot 2017-02-16 23 08 45
@bbondy bbondy added this to the 0.13.5 milestone Feb 17, 2017
@NejcZdovc
Copy link
Contributor

If you hover over them, they render correctly. Even if you move the mouse out later they stay in the correct format.

@cezaraugusto cezaraugusto mentioned this issue Feb 20, 2017
Merged
4 tasks
@alexwykoff alexwykoff mentioned this issue Feb 26, 2017
Closed
This was referenced Mar 1, 2017
Closed
Closed
Closed
Closed
This was referenced Mar 3, 2017
Closed
Closed
@cezaraugusto
Copy link
Contributor

re-opening after report from @BrendanEich. not always reproducible but definitely happens after some trials. Should be fixed by intersection observer api for tabs (tracked in #10509)

@cezaraugusto cezaraugusto reopened this Aug 19, 2017
@cezaraugusto cezaraugusto modified the milestones: 0.20.x (Developer Channel), 0.13.5 Aug 19, 2017
@cezaraugusto
Copy link
Contributor

pushed to 0.20.x to match #10509

cezaraugusto added a commit that referenced this issue Aug 28, 2017
@cezaraugusto
improve performance for tabs, include intersectionObserver
efeb942 
fix #10611
fix #10582
fix #10544
fix #10509
fix #10123
fix #9998
fix #9398
fix #8414
fix #7925
fix #7730
fix #7301
fix #6957
@cezaraugusto cezaraugusto mentioned this issue Aug 28, 2017
Merged
cezaraugusto added a commit that referenced this issue Aug 29, 2017
@cezaraugusto
improve performance for tabs, include intersectionObserver
7660913 
fix #10611
fix #10582
fix #10544
fix #10509
fix #10123
fix #9998
fix #9398
fix #8414
fix #7925
fix #7730
fix #7301
fix #6957
@ghost ghost added the sprint/1 label Sep 13, 2017
cezaraugusto added a commit that referenced this issue Sep 14, 2017
@cezaraugusto
UI bug fixing
23fcc08 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7925
fix #10544
fix #10123
fix #10509
fix #10582
fix #10611
cezaraugusto added a commit that referenced this issue Sep 14, 2017
@cezaraugusto
UI bug fixing
7c58204 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
cezaraugusto added a commit that referenced this issue Sep 15, 2017
@cezaraugusto
UI bug fixing
2427327 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
cezaraugusto added a commit that referenced this issue Sep 15, 2017
@cezaraugusto
UI bug fixing
94ba1a1 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
cezaraugusto added a commit that referenced this issue Sep 19, 2017
@cezaraugusto
UI bug fixing
321281b 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix #6716
fix #7301
fix #7730
fix #7765
fix #7925
fix #10123
fix #10509
fix #10544
fix #10582
fix #10611
fix #10838
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@cezaraugusto @syuan100
UI bug fixing
ac96632 
- tabs can now respond beautifully to intersections
- Also BEMify tabs
Auditors: @bsclifton, @luixxiul
fix brave#6716
fix brave#7301
fix brave#7730
fix brave#7765
fix brave#7925
fix brave#10123
fix brave#10509
fix brave#10544
fix brave#10582
fix brave#10611
fix brave#10838
This was referenced Dec 20, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
bug feature/tabsbar misc/fullscreen-option QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

improve tabs performance and UI with this one simple trick brave/browser-laptop
8 participants
@bbondy @alexwykoff @luixxiul @cezaraugusto @NejcZdovc @srirambv @cndouglas @LaurenWags