Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Show base domain urlbar suggestions along with deep linked history suggestions #7533

Closed
aekeus opened this issue Mar 8, 2017 · 0 comments · Fixed by #7534
Closed

Show base domain urlbar suggestions along with deep linked history suggestions #7533

aekeus opened this issue Mar 8, 2017 · 0 comments · Fixed by #7534
Assignees
@aekeus
Labels
bug feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.14.0

Comments

@aekeus
Copy link
Member

aekeus commented Mar 8, 2017 •
edited by luixxiul
Loading

Test plan

#7534 (comment)

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    We should show based domains (github.com) in the urlbar suggestion list if there is a history item with a location containing a path (github.com/brave/browser-laptop)

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    All

  • Steps to reproduce:

    1. Visit https://www.github.com/brave
    2. Open a new tab a type github
    3. http://www.github.com is not shown

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes
@aekeus aekeus added this to the 0.13.6 milestone Mar 8, 2017
@aekeus aekeus self-assigned this Mar 8, 2017
aekeus added a commit that referenced this issue Mar 8, 2017
@aekeus
Add short domains to url suggestions when long url is present
73c0cc2 
Auditors: @bbondy

Test Plan:

  1. Clear history
  2. Visit http://www.github.com/brave
  3. Verify one history item in about:history
  4. Open new tab
  5. type 'github'
  6. Verify that http://www.github.com suggestion is present

Fixes: #7533
@aekeus aekeus mentioned this issue Mar 8, 2017
Merged
4 tasks
@luixxiul luixxiul mentioned this issue Mar 13, 2017
Closed
This was referenced Mar 14, 2017
Closed
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Mar 17, 2017
Closed
53 tasks
@bsclifton bsclifton mentioned this issue Mar 20, 2017
Closed
@alexwykoff alexwykoff mentioned this issue Mar 21, 2017
Closed
@alexwykoff alexwykoff changed the title Show base domain urlbar suggestions along with deep linked history suggestions Fixed urlbar suggestions to show base domain along with deep linked history suggestions Mar 27, 2017
@alexwykoff alexwykoff mentioned this issue Mar 28, 2017
Closed
@luixxiul luixxiul changed the title Fixed urlbar suggestions to show base domain along with deep linked history suggestions Show base domain urlbar suggestions along with deep linked history suggestions Sep 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aekeus aekeus

Labels
bug feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

Add short domains to url suggestions when long url is present brave/browser-laptop
4 participants
@aekeus @alexwykoff @luixxiul @srirambv