Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Back/forward history menu not dismissed on back/forward click #7645

Closed
cndouglas opened this issue Mar 10, 2017 · 6 comments
Closed

Back/forward history menu not dismissed on back/forward click #7645

cndouglas opened this issue Mar 10, 2017 · 6 comments
Labels
bug fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. wontfix

Comments

@cndouglas
Copy link

cndouglas commented Mar 10, 2017

  • Did you search for similar issues before submitting this one?
    Yes.

  • Describe the issue you encountered:
    If the back/forward history menu is visible, clicking the back or forward button does not dismiss it.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS (likely all)

  • Brave Version (revision SHA):
    0.13.5 (1db81cb)

  • Steps to reproduce:

    1. Open a new tab and navigate to any page with a link.
    2. Click the link.
    3. Hold down on the back button to display the back history menu.
    4. Click the back button.
  • Actual result:
    The back history menu is not dismissed.

  • Expected result:
    The back history menu should be dismissed.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    I did not try.

  • Is this an issue in the currently released version?
    Yes, 0.13.5.

  • Can this issue be consistently reproduced?
    Yes.

  • Extra QA steps:

    1. Open a new tab and navigate to any page with a link.
    2. Click the link.
    3. Hold down on the back button to display the back history menu.
    4. Click the back button.
    5. Make sure the back history menu is dismissed.
  • Screenshot if needed:
    Screencast:
    untitled

  • Any related issues:
    None.

@cndouglas cndouglas added the bug label Mar 10, 2017
@cndouglas
Copy link
Author

Same thing with the refresh button and new tab button.

@bsclifton
Copy link
Member

Fix would be similar to the one done for hamburger menu that @Hapcy implemented with #6405

@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@PatMB30
Copy link

PatMB30 commented Apr 21, 2018

Hi, I'd like to work on this issue. I've double checked what @bsclifton suggested looking into (#6405), and to make sure I understand i'd like to ask; should the back button's submenu disappear once the mouse moves away from the button or its submenu? Also, any hint on how to handle the mouse's position in regards to that would be appreciated.

@cndouglas
Copy link
Author

cndouglas commented Apr 22, 2018

@PatMB30

should the back button's submenu disappear once the mouse moves away from the button or its submenu?

I haven't seen the behavior you describe anywhere else. I just tried both Firefox and Safari, and the context menu stays visible wherever you move the mouse pointer. So I suggest that you keep the behavior consistent with other major browsers.

@PatMB30
Copy link

PatMB30 commented Apr 22, 2018

@liunkae
I've tested the behavior with Chrome and came to the same conclusion, thank you for your input though. I figure the best thing would be to have the back button's submenu disappear once the back button has been clicked once after having been long-pressed. I'm having difficulty figuring out how to close the back button's menu though.

@bsclifton bsclifton added the fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. label Jun 28, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Jun 28, 2018
@bsclifton
Copy link
Member

bsclifton commented Jun 28, 2018

Unless @PatMB30 wanted to fix this, I think we won't be able to address this issue. However, it is fixed with Brave Core which is coming soon 😄👍 Closing issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. wontfix
Projects
None yet
Development

No branches or pull requests

3 participants