This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix/hamburger menu appearance #6405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Considering the context menus disappear on the mousedown event I added hamburgerMenuWasOpen to the windowState to be able to check it when the hamburgerMenu's onClick is executed Closes #4921
The added tests test that the hamburgerMenu's context menu appears, disappears, reappears on different clicks
|
+1 👍 Works great! |
|
@liunkae I formally assigned you, in case you wanted to approve. If it looks good, go ahead and drop the |
cndouglas
approved these changes
Jan 10, 2017
|
Recent CI passed, merging! Thanks for the change, @Hapcy 😄 |
|
Great job w/ the tests, BTW 😄 |
This was referenced Feb 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed). - I don't think the commits need squashing.Test Plan: