Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Clicking the hamburger menu a second time should close the menu #4921

Closed
asadotzler opened this issue Oct 18, 2016 · 1 comment
Closed

Clicking the hamburger menu a second time should close the menu #4921

asadotzler opened this issue Oct 18, 2016 · 1 comment
Labels
bug/good-first-bug QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.2

Comments

@asadotzler
Copy link

Did you search for similar issues before submitting this one? Yes

Describe the issue you encountered: Clicking the hamburger menu a second time should close the menu but it re-opens it instead

Expected behavior: Menu should close on second click

  • Platform (Win7, 8, 10? macOS? Linux distro?): WIndows 10
  • Brave Version: 0.12.5
  • Steps to reproduce:
    1. click the hamburger menu
    2. click the menu a second time
    3. observe the menu close and re-open
  • Screenshot if needed:
  • Any related issues:
@Hapcy Hapcy mentioned this issue Dec 23, 2016
Merged
4 tasks
@luixxiul luixxiul added this to the contributor backlog milestone Dec 23, 2016
@bsclifton bsclifton modified the milestones: 0.13.1, contributor backlog Jan 9, 2017
@bsclifton
Copy link
Member

Fixed with #6405 which was merged into branch 0.13.1-branch.

bsclifton pushed a commit that referenced this issue Jan 14, 2017
@Hapcy @bsclifton
Stop hamburger menu from reopening
6cffeb0 
Considering the context menus disappear on the mousedown event
I added hamburgerMenuWasOpen to the windowState to be able to
check it when the hamburgerMenu's onClick is executed

Closes #4921
bsclifton pushed a commit that referenced this issue Jan 17, 2017
@Hapcy @bsclifton
Stop hamburger menu from reopening
4996c43 
Considering the context menus disappear on the mousedown event
I added hamburgerMenuWasOpen to the windowState to be able to
check it when the hamburgerMenu's onClick is executed

Closes #4921
bsclifton pushed a commit that referenced this issue Jan 17, 2017
@Hapcy @bsclifton
Stop hamburger menu from reopening
d9f37bf 
Considering the context menus disappear on the mousedown event
I added hamburgerMenuWasOpen to the windowState to be able to
check it when the hamburgerMenu's onClick is executed

Closes #4921
bsclifton pushed a commit that referenced this issue Jan 18, 2017
@Hapcy @bsclifton
Stop hamburger menu from reopening
be391eb 
Considering the context menus disappear on the mousedown event
I added hamburgerMenuWasOpen to the windowState to be able to
check it when the hamburgerMenu's onClick is executed

Closes #4921
bsclifton pushed a commit that referenced this issue Jan 20, 2017
@Hapcy @bsclifton
Stop hamburger menu from reopening
8edd85a 
Considering the context menus disappear on the mousedown event
I added hamburgerMenuWasOpen to the windowState to be able to
check it when the hamburgerMenu's onClick is executed

Closes #4921
NejcZdovc pushed a commit to NejcZdovc/browser-laptop that referenced this issue Jan 23, 2017
@Hapcy @NejcZdovc
Stop hamburger menu from reopening
fb75a83 
Considering the context menus disappear on the mousedown event
I added hamburgerMenuWasOpen to the windowState to be able to
check it when the hamburgerMenu's onClick is executed

Closes brave#4921
bsclifton pushed a commit that referenced this issue Jan 23, 2017
@Hapcy @bsclifton
Stop hamburger menu from reopening
d630c0b 
Considering the context menus disappear on the mousedown event
I added hamburgerMenuWasOpen to the windowState to be able to
check it when the hamburgerMenu's onClick is executed

Closes #4921
bsclifton pushed a commit that referenced this issue Jan 24, 2017
@Hapcy @bsclifton
Stop hamburger menu from reopening
69ab7c4 
Considering the context menus disappear on the mousedown event
I added hamburgerMenuWasOpen to the windowState to be able to
check it when the hamburgerMenu's onClick is executed

Closes #4921
bsclifton pushed a commit that referenced this issue Jan 25, 2017
@Hapcy @bsclifton
Stop hamburger menu from reopening
3a9da72 
Considering the context menus disappear on the mousedown event
I added hamburgerMenuWasOpen to the windowState to be able to
check it when the hamburgerMenu's onClick is executed

Closes #4921
bsclifton pushed a commit that referenced this issue Jan 25, 2017
@Hapcy @bsclifton
Stop hamburger menu from reopening
2279d6b 
Considering the context menus disappear on the mousedown event
I added hamburgerMenuWasOpen to the windowState to be able to
check it when the hamburgerMenu's onClick is executed

Closes #4921
This was referenced Feb 3, 2017
Closed
Closed
Closed
Closed
@srirambv srirambv mentioned this issue Feb 13, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug/good-first-bug QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.2
Development

No branches or pull requests
6 participants
@aekeus @asadotzler @bbondy @luixxiul @bsclifton @srirambv