Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Unit test failing #7667

Closed
NejcZdovc opened this issue Mar 12, 2017 · 0 comments
Closed

Unit test failing #7667

NejcZdovc opened this issue Mar 12, 2017 · 0 comments
Assignees
@NejcZdovc
Labels
automated-tests QA/checked QA/test-plan-specified release-notes/exclude
Milestone
0.14.0

Comments

@NejcZdovc
Copy link
Contributor

Unit test is failing.

1) suggestion unit tests createVirtualHistoryItems handles input being null/undefined:
     AssertionError: Map {} deepEqual []
      at Context.<anonymous> (test/unit/app/renderer/lib/suggestionTest.js:43:14)

Change was made here c738e7f
@NejcZdovc NejcZdovc added this to the 0.13.6 milestone Mar 12, 2017
@NejcZdovc NejcZdovc self-assigned this Mar 12, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 12, 2017
@NejcZdovc
Fixing unit tests
19647a8 
Resolves brave#7667

Auditors:
@bsclifton @aekeus

Test Plan:
- unit test should be green
@NejcZdovc NejcZdovc mentioned this issue Mar 12, 2017
Merged
4 tasks
NejcZdovc added a commit that referenced this issue Mar 12, 2017
@NejcZdovc
Merge pull request #7668 from NejcZdovc/hotfix/#7667-unit-test
f43488a 
Fixing unit test
This was referenced Mar 14, 2017
Closed
Closed
Closed
Closed
This was referenced Mar 17, 2017
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Mar 28, 2017
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
automated-tests QA/checked QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
3 participants
@alexwykoff @luixxiul @NejcZdovc