This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
File download hangs if Brave does not have write permission to target directory #7747
Assignees
Labels
bug
feature/download
priority/P3
Major loss of function.
QA/checked-Linux
QA/checked-macOS
QA/checked-Win64
QA/test-plan-specified
release-notes/include
Milestone
Comments
syuan100
added a commit
to syuan100/browser-laptop
that referenced
this issue
Sep 9, 2017
When a user downloads a file to a location that they do not have access to, it currently just says "Downloading... 0%". This is to add a download state to indicate that the user doesn't have access to the director they are trying to download into. Commit list: - Add new download state - Update state if directory is unauthorized - Update electron download state change - Add 'Unauthorized' download state to 'clear completed downloads' reducer - Add isUnauthorized getter - Add unauthorized state as part of condition for hiding progress display - Add isUnauthorized to condition for rendering a download item - Set unauthorized as a stop condition for downloads - Set getL10nId for unauthorized downloads - Add 'unauthorized' as a style class for finished download items - Add downloadUnauthorized locale id for all languages TODO: Update localization for all languages for this state Fixes brave#7747
syuan100
added a commit
to syuan100/browser-laptop
that referenced
this issue
Sep 10, 2017
When a user downloads a file to a location that they do not have access to, it currently just says "Downloading... 0%". This is to add a download state to indicate that the user doesn't have access to the director they are trying to download into. Commit list: - Add new download state - Update state if directory is unauthorized - Update electron download state change - Add 'Unauthorized' download state to 'clear completed downloads' reducer - Add isUnauthorized getter - Add unauthorized state as part of condition for hiding progress display - Add isUnauthorized to condition for rendering a download item - Set unauthorized as a stop condition for downloads - Set getL10nId for unauthorized downloads - Add 'unauthorized' as a style class for finished download items - Add downloadUnauthorized locale id for all languages TODO: Update localization for all languages for this state Fixes brave#7747 Update test Return 0% when download totalBytes is 0 or undefined Fix brave#10264 Updated code to handle falsey inputs + added more unit tests :) Auditors: @diracdeltas Test Plan: `npm run unittest -- --grep="downloadUtil"` Move properties inside main.less to window.less Closes brave#10860 Auditors: Test Plan: 1. npm run watch 2. npm start 3. Make sure the browser starts 4. Open the devtool and make sure the two properties are applied Converted Country Textbox to Select Dropdown Creating a dropdown for the country list in the about:autofill panel Fix brave#9053 Small cleanup for autofill country list per discussion in PR Auditors: @dfperry5 Fix two issues - handle when locale is called with null/undefined/falsey value (before would fail on toLowerCase()) - handle situation where activeTab is not set and developer tools are opened (will be fixed soon by @bbondy) Auditors: @bbondy, @dfperry5 Issue brave#9053 - Updating so that first option on dropdown for countries is a blank modified: app/renderer/components/autofill/autofillAddressPanel.js modified: app/renderer/components/autofill/autofillAddressPanel.js modified: app/renderer/components/autofill/autofillAddressPanel.js modified: app/renderer/components/autofill/autofillAddressPanel.js Add 'CommonFormFullWidthDropdown' to commonForm.js Auditors: @cezaraugusto Test Plan: 1. Open about:autofill 2. Click 'Add Address' Update autofill webdriver tests to use Country as a dropdown value instead of a text field Auditors: @dfperry5, @darkdh, @luixxiul Test Plan: `npm run test -- --grep="Autofill" Style Edits Auditors: Test Plan:
syuan100
added a commit
to syuan100/browser-laptop
that referenced
this issue
Sep 10, 2017
When a user downloads a file to a location that they do not have access to, it currently just says "Downloading... 0%". This is to add a download state to indicate that the user doesn't have access to the director they are trying to download into. Commit list: - Add new download state - Update state if directory is unauthorized - Update electron download state change - Add 'Unauthorized' download state to 'clear completed downloads' reducer - Add isUnauthorized getter - Add unauthorized state as part of condition for hiding progress display - Add isUnauthorized to condition for rendering a download item - Set unauthorized as a stop condition for downloads - Set getL10nId for unauthorized downloads - Add 'unauthorized' as a style class for finished download items - Add downloadUnauthorized locale id for all languages - Update tests - Fix styling TODO: Update localization for all languages for this state Fixes brave#7747
7 tasks
syuan100
added a commit
to syuan100/browser-laptop
that referenced
this issue
Sep 11, 2017
When a user downloads a file to a location that they do not have access to, it currently just says "Downloading... 0%". This is to add a download state to indicate that the user doesn't have access to the director they are trying to download into. Commit list: - Add new download state - Update state if directory is unauthorized - Update electron download state change - Add 'Unauthorized' download state to 'clear completed downloads' reducer - Add isUnauthorized getter - Add unauthorized state as part of condition for hiding progress display - Add isUnauthorized to condition for rendering a download item - Set unauthorized as a stop condition for downloads - Set getL10nId for unauthorized downloads - Add 'unauthorized' as a style class for finished download items - Add downloadUnauthorized locale id for all languages - Update tests - Fix styling TODO: Update localization for all languages for this state Fixes brave#7747
ghost
assigned
bsclifton
pushed a commit
to syuan100/browser-laptop
that referenced
this issue
Nov 9, 2017
When a user downloads a file to a location that they do not have access to, it currently just says "Downloading... 0%". This is to add a download state to indicate that the user doesn't have access to the director they are trying to download into. Commit list: - Add new download state - Update state if directory is unauthorized - Update electron download state change - Add 'Unauthorized' download state to 'clear completed downloads' reducer - Add isUnauthorized getter - Add unauthorized state as part of condition for hiding progress display - Add isUnauthorized to condition for rendering a download item - Set unauthorized as a stop condition for downloads - Set getL10nId for unauthorized downloads - Add 'unauthorized' as a style class for finished download items - Add downloadUnauthorized locale id for all languages - Update tests - Fix styling Fixes brave#7747
bsclifton
pushed a commit
to syuan100/browser-laptop
that referenced
this issue
Nov 13, 2017
When a user downloads a file to a location that they do not have access to, it currently just says "Downloading... 0%". This is to add a download state to indicate that the user doesn't have access to the director they are trying to download into. Commit list: - Add new download state - Update state if directory is unauthorized - Update electron download state change - Add 'Unauthorized' download state to 'clear completed downloads' reducer - Add isUnauthorized getter - Add unauthorized state as part of condition for hiding progress display - Add isUnauthorized to condition for rendering a download item - Set unauthorized as a stop condition for downloads - Set getL10nId for unauthorized downloads - Add 'unauthorized' as a style class for finished download items - Add downloadUnauthorized locale id for all languages - Update tests - Fix styling Fixes brave#7747
This was referenced Feb 20, 2018
|
Works on Windows shows the following error |
This was referenced Mar 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
#10882 (comment)
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
From community
https://community.brave.com/t/file-download-hangs-if-brave-does-not-have-write-permission-to-target-directory/1719
Platform (Win7, 8, 10? macOS? Linux distro?):
Macbook Pro OSX 10.12.3
Brave Version (revision SHA):
Macbook Pro OSX 10.12.3
Steps to reproduce:
Extra QA steps:
1.
2.
3.
Screenshot if needed:
Any related issues:
The text was updated successfully, but these errors were encountered: