Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

autofill session/private tab tests are failing #7763

Closed
diracdeltas opened this issue Mar 17, 2017 · 5 comments · Fixed by #7777
Closed

autofill session/private tab tests are failing #7763

diracdeltas opened this issue Mar 17, 2017 · 5 comments · Fixed by #7777
Assignees
@darkdh
Labels
automated-tests bug feature/autofill feature/private-tabs

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Mar 17, 2017 •
edited
Loading

@diracdeltas diracdeltas added this to the 0.14.0 milestone Mar 17, 2017
@diracdeltas
Copy link
Member Author

looks like in the private/session tabs, the autofill menu appears briefly and disappears before it can be clicked. i am actually seeing this behavior in all tabs when i run npm start. for every keystroke in a form field, i see 'show-autofill-popup' emitted once followed immediately by 'hide-autofill-popup' emitted twice.

cc @darkdh

@bsclifton
Copy link
Member

Great find, @diracdeltas 😄 The real thing is breaking too (just reported by @srirambv). I'll go back and see which are the last passing tests

@bsclifton
Copy link
Member

Last successful run appears to be right before we upgraded Muon to 2.56.9:
https://travis-ci.org/brave/browser-laptop/builds/211549904

@darkdh
Copy link
Member

darkdh commented Mar 18, 2017

This commit broke the popup
(brave/muon@fcaecc2)
It will call https://chromium.googlesource.com/chromium/src.git/+/56.0.2924.87/components/autofill/content/browser/content_autofill_driver_factory.cc#127
then
https://github.com/brave/muon/blob/29ab58342ec11a37d55f2f2ad7e32c89238b7976/atom/browser/autofill/atom_autofill_client.cc#L198

darkdh added a commit that referenced this issue Mar 18, 2017
@darkdh
Follow up of brave/muon#170
3964c34 
fix #7763
fix #7768

Auditors: @bridiver, @bbondy, @bsclifton

Test Plan: Covered by automatic test
@darkdh darkdh mentioned this issue Mar 18, 2017
Merged
4 tasks
darkdh added a commit that referenced this issue Mar 18, 2017
@darkdh
Follow up of brave/muon#170
061d102 
requires brave/muon#170

fix #7763
fix #7768

Auditors: @bridiver, @bbondy, @bsclifton

Test Plan: Covered by automatic test
@alexwykoff alexwykoff mentioned this issue Mar 21, 2017
Closed
44 tasks
@bsclifton
Copy link
Member

bsclifton commented Mar 21, 2017 •
edited
Loading

Will be fixed now that brave/muon#170 has been accepted; we just need a new prebuilt for Muon. Closing this issue and removing milestone (as there is no testing needed)

@bsclifton bsclifton removed this from the 0.14.0 milestone Mar 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
automated-tests bug feature/autofill feature/private-tabs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Follow up of https://github.com/brave/muon/pull/170 brave/browser-laptop
4 participants
@diracdeltas @luixxiul @bsclifton @darkdh