Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Zoom is not saved when you close the browser and restore on a single site #7832

Closed
luixxiul opened this issue Mar 22, 2017 · 1 comment
Closed

Zoom is not saved when you close the browser and restore on a single site #7832

luixxiul opened this issue Mar 22, 2017 · 1 comment
Labels
bug QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.14.0

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Mar 22, 2017 •
edited
Loading

Describe the issue you encountered:
Zoom is not saved when you close the browser and restore on a single site.

  • Platform (Win7, 8, 10? macOS? Linux distro?):

  • Brave Version (revision SHA): 0.14.0 Preview 4

  • Steps to reproduce:

    1. Test zoom saved when you close the browser and restore on a single site.

  • Expected result: Zoom should be saved when you close the browser and restore on a single site

  • Will the steps above reproduce in a fresh profile? Yes

  • Any related issues:
@luixxiul luixxiul added this to the 0.14.0 milestone Mar 22, 2017
@diracdeltas diracdeltas self-assigned this Mar 22, 2017
diracdeltas added a commit that referenced this issue Mar 23, 2017
@diracdeltas
Fix zoom level on browser restore
642c0dc 
and remove deprecated zoom level site setting.

fix #7832

Test Plan:
1. launch clean instance of brave
2. go to example.com and change the zoom level
3. close brave
4. reopen brave
5. example.com should load with the previous zoom setting
@diracdeltas diracdeltas mentioned this issue Mar 23, 2017
Closed
4 tasks
bridiver added a commit to brave/muon that referenced this issue Mar 23, 2017
@bridiver
scoped_refptr -> std::unique_ptr to ensure proper destruction
7baccbe 
fix brave/browser-laptop#7832
auditors @bbondy @diracdeltas
bridiver added a commit to brave/muon that referenced this issue Mar 23, 2017
@bridiver
scoped_refptr -> std::unique_ptr to ensure proper destruction
5f39fbf 
fix brave/browser-laptop#7832
auditors @bbondy @diracdeltas
@diracdeltas diracdeltas removed their assignment Mar 23, 2017
@bsclifton
Copy link
Member

bsclifton commented Mar 23, 2017 •
edited
Loading

Closing issue as it was fixed with brave/muon@5f39fbf; next Muon build will include it

This was referenced Mar 28, 2017
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Mar 30, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

Fix zoom level on browser restore brave/browser-laptop
5 participants
@diracdeltas @alexwykoff @luixxiul @bsclifton @srirambv