This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Lion badge should show count for fingerprint block as well #7886
Assignees
Labels
design
A design change, especially one which needs input from the design team.
feature/shields
polish
Nice to have — usually related to front-end/visual tasks.
QA/checked-Linux
QA/checked-macOS
QA/checked-Win32
QA/checked-Win64
QA/test-plan-specified
release-notes/exclude
Milestone
Comments
srirambv
added
design
|
This is by design. @bradleyrichter should we include fingerprint as well? |
|
Actually, if the display is 0, then the badge should be hidden.
Same for shields down.
… On Mar 25, 2017, at 4:17 AM, Nejc Zdovc ***@***.***> wrote:
This is by design. @bradleyrichter should we include fingerprint as well?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@bradleyrichter Not sure that I follow. I already created PR that hides badge if count is 0 #7877. What we are talking here is if we should display only "Ad or Tracker Blocked" (this is how we display it now) or we should add "Fingerprinting Method Blocked" to this count as well. |
|
In my opinion it should display fingerprinting too but it's your choice👍 |
|
Sorry. The screen shot threw me off since it had a zero.
Let's show a sum of all shield types. It will be helpful to know when at least 1 item is blocked.
… On Mar 25, 2017, at 2:07 PM, Nejc Zdovc ***@***.***> wrote:
@bradleyrichter Not sure that I follow. I already created PR that hides badge if count is 0 #7877. What we are talking here is if we should display only "Ad or Tracker Blocked" (this is how we display it now) or we should add "Fingerprinting Method Blocked" to this count as well.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@bradleyrichter so sum all 4 of them, even HTTPS upgrades? |
NejcZdovc
referenced
this issue
Mar 26, 2017
Resolves #7859 Auditors: @bradleyrichter @jonathansampson @bsclifton Test Plan: - go to youtube - play some videos - check if licon badge has the same number as shield panel
|
I feel it should be only for
|
|
@srirambv I agree |
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Mar 26, 2017
Resolves brave#7886 Auditors: @bsclifton Test Plan: - Visit icloud.com with fingerprint enabled - badge count should be 1
4 tasks
bsclifton
added a commit
that referenced
this issue
Mar 27, 2017
Adds fingerprint and scripts to the lion badge count
bsclifton
pushed a commit
that referenced
this issue
Mar 27, 2017
Resolves #7886 Auditors: @bsclifton Test Plan: - Visit icloud.com with fingerprint enabled - badge count should be 1
This was referenced Mar 28, 2017
|
marked as |
bridiver
pushed a commit
that referenced
this issue
Apr 4, 2017
Resolves #7886 Auditors: @bsclifton Test Plan: - Visit icloud.com with fingerprint enabled - badge count should be 1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Lion badge should show count for fingerprint block as well
Platform (Win7, 8, 10? macOS? Linux distro?):
All
Brave Version (revision SHA):
Brave 0.14.0
rev ffa6f8f
Steps to reproduce:
Actual result:
No count shown when only fingerprint method is blocked
Expected result:
Should show count for blocked fingerprint method as well along with adblock and script block
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Yes
Is this an issue in the currently released version?
N/A
Can this issue be consistently reproduced?
Yes
Extra QA steps:
1.
2.
3.
Screenshot if needed:
Any related issues:
cc: @NejcZdovc
The text was updated successfully, but these errors were encountered: