Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

New private tab has a blank page favicon and NewTab text is not visible #7912

Closed
srirambv opened this issue Mar 27, 2017 · 2 comments
Closed

New private tab has a blank page favicon and NewTab text is not visible #7912

srirambv opened this issue Mar 27, 2017 · 2 comments
Assignees
@bbondy
Labels
feature/newtab feature/private-tabs misc/favicon QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.14.0

Comments

@srirambv
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    New private tab has a blank page favicon and NewTab text is not visible

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.14.0
    rev 61b6b6b, b4289c0

  • Steps to reproduce:

    1. Do a clean install of 0.14.0 preview 7
    2. Open a new private tab via shortcut/long press on + button
    3. Tab has a blank page favicon and the tab title NewTab is not visible
      Issue from preview 6 onwards

  • Actual result:
    New private tab has a blank page favicon

  • Expected result:
    Should not have the favicon

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    image

  • Any related issues:
    cc: @cezaraugusto
@srirambv srirambv added this to the 0.14.0 milestone Mar 27, 2017
@cezaraugusto cezaraugusto mentioned this issue Mar 27, 2017
Closed
@bbondy
Copy link
Member

bbondy commented Mar 28, 2017

This is because of the changes here:
17b7cbe

The changes are good but it causes a problem since we have an outstanding bug where about: pages do not load in private tabs.

Options are:

  1. Get private tabs to work on private tabs.
  2. Add some hacky code for about: pages only for the did-fail-provisional-load event

In particular e.currentURL will be blank, but we could hack it to be the about: page if it is a private tab.

@bridiver thoughts? Would it be hard to get private tabs working with about: pages?

@bbondy bbondy assigned bbondy and unassigned cezaraugusto Mar 28, 2017
@bbondy
Copy link
Member

bbondy commented Mar 28, 2017

I'm going to try adding an API so we can have private tab extensions

@bbondy bbondy closed this as completed in cc51723 Mar 28, 2017
bsclifton pushed a commit that referenced this issue Mar 28, 2017
@bbondy @bsclifton
Allow Brave extension in private tabs
e6fba42 
Fix #7912

- Main frame loads are not allowed with spanning incognito mode, so
  changed to split.
  Sync shouldn't be allowed in incognito, so disabled that.
- Added handling in ledger to not log pages for private tabs.

Auditors: @bridiver
This was referenced Mar 28, 2017
Closed
Closed
Closed
Closed
bbondy added a commit that referenced this issue Mar 29, 2017
@bbondy
Move incognito newtab check into props
6ae4e0d 
Auditors: @bridiver

Related to #7912
bbondy added a commit that referenced this issue Mar 29, 2017
@bbondy
Move incognito newtab check into props
ecca4ff 
Auditors: @bridiver

Related to #7912
@alexwykoff alexwykoff changed the title New private tab has a blank page favicon and NewTab text is not visible Fixed new private tab favicon and text display Mar 29, 2017
This was referenced Mar 30, 2017
Closed
Closed
bridiver pushed a commit that referenced this issue Apr 4, 2017
@bbondy @bridiver
Allow Brave extension in private tabs
7c79c0a 
Fix #7912

- Main frame loads are not allowed with spanning incognito mode, so
  changed to split.
  Sync shouldn't be allowed in incognito, so disabled that.
- Added handling in ledger to not log pages for private tabs.

Auditors: @bridiver
bridiver pushed a commit that referenced this issue Apr 4, 2017
@bbondy @bridiver
Move incognito newtab check into props
5ef196b 
Auditors: @bridiver

Related to #7912
@luixxiul luixxiul changed the title Fixed new private tab favicon and text display New private tab has a blank page favicon and NewTab text is not visible Aug 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbondy bbondy

Labels
feature/newtab feature/private-tabs misc/favicon QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
5 participants
@bbondy @alexwykoff @luixxiul @cezaraugusto @srirambv