Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed bookmarks are re-synced (uploaded) on every load #8408

Closed
ayumi opened this issue Apr 20, 2017 · 0 comments
Closed

Fixed bookmarks are re-synced (uploaded) on every load #8408

ayumi opened this issue Apr 20, 2017 · 0 comments
Assignees
@ayumi
Labels
feature/bookmarks feature/sync QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.15.0

Comments

@ayumi
Copy link
Contributor

ayumi commented Apr 20, 2017 •
edited by luixxiul
Loading

Test plan

#8409 (comment)

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    With Sync, bookmarks are synced every browser load.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    MacOS

  • Brave Version (revision SHA):
    dev, master @ 15b4dbc

  • Steps to reproduce:

    1. Enable Sync on a fresh profile.
    2. Visit archive.org and bookmark it. Terminal should show that it synced.
    3. Close archive.org tab.
    4. Restart Brave.
    5. Examine terminal for sync init and sent records.

  • Actual result:
    Bookmark is sent again.

  • Expected result:
    Bookmark should not be sent.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Any related issues:
    Startup Performance decrease when sync is turned on #8354
@ayumi ayumi self-assigned this Apr 20, 2017
@ayumi ayumi added this to the 0.15.0 milestone Apr 20, 2017
ayumi added a commit that referenced this issue Apr 20, 2017
@ayumi
Don't reupload bookmarks to Sync every load
46de475 
Fix #8408

Auditors: @diracdeltas @bbondy

Test Plan:
1. Open Brave and enable Sync.
2. Visit archive.org and bookmark it. Terminal should show that it synced.
3. Close archive.org tab.
4. Restart Brave.
5. Examine terminal. Bookmark shouldn't be re-synced.
@ayumi ayumi mentioned this issue Apr 20, 2017
Merged
4 tasks
ayumi added a commit that referenced this issue Apr 20, 2017
@ayumi
Don't reupload bookmarks to Sync every load
6821af5 
Fix #8408

Auditors: @diracdeltas @bbondy

Test Plan:
1. Open Brave and enable Sync.
2. Visit archive.org and bookmark it. Terminal should show that it synced.
3. Close archive.org tab.
4. Restart Brave.
5. Examine terminal. Bookmark shouldn't be re-synced.
bsclifton pushed a commit that referenced this issue Apr 20, 2017
@ayumi @bsclifton
Don't reupload bookmarks to Sync every load
5ece02d 
Fix #8408

Auditors: @diracdeltas @bbondy

Test Plan:
1. Open Brave and enable Sync.
2. Visit archive.org and bookmark it. Terminal should show that it synced.
3. Close archive.org tab.
4. Restart Brave.
5. Examine terminal. Bookmark shouldn't be re-synced.
@ayumi ayumi mentioned this issue Apr 20, 2017
Closed
This was referenced Apr 21, 2017
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
@alexwykoff alexwykoff changed the title Bookmarks are re-synced (uploaded) on every load Fixed bookmarks are re-synced (uploaded) on every load Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ayumi ayumi

Labels
feature/bookmarks feature/sync QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
5 participants
@ayumi @luixxiul @cezaraugusto @NejcZdovc @srirambv