Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

noscript approvals from private tabs apply to regular tabs #8779

Closed
diracdeltas opened this issue May 9, 2017 · 0 comments · Fixed by #8783
Closed

noscript approvals from private tabs apply to regular tabs #8779

diracdeltas opened this issue May 9, 2017 · 0 comments · Fixed by #8783

Comments

@diracdeltas
Copy link
Member

diracdeltas commented May 9, 2017

Test plan

#8783 (comment)


if you click on the noscript icon in a private tab to 'allow once', the setting also gets applied to the same site in a regular tab.

@diracdeltas diracdeltas added this to the 0.15.400 milestone May 9, 2017
@diracdeltas diracdeltas self-assigned this May 9, 2017
diracdeltas added a commit that referenced this issue May 10, 2017
fix #8779

Test Plan:
1. disable scripts on twitter.com
2. open twitter.com in a private tab. scripts should be disabled.
3. click the noscript icon to allow scripts in the private tab. it should work.
4. load twitter again in a regular tab. scripts should still be disabled.
diracdeltas added a commit that referenced this issue May 10, 2017
fix #8779

Test Plan:
1. disable scripts on twitter.com
2. open twitter.com in a private tab. scripts should be disabled.
3. click the noscript icon to allow scripts in the private tab.
4. load twitter again in a regular tab. scripts should still be disabled.
kspearrin pushed a commit to kspearrin/browser-laptop that referenced this issue May 11, 2017
fix brave#8779

Test Plan:
1. disable scripts on twitter.com
2. open twitter.com in a private tab. scripts should be disabled.
3. click the noscript icon to allow scripts in the private tab.
4. load twitter again in a regular tab. scripts should still be disabled.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.