This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor add/edit bookmark #8927

Closed

NejcZdovc opened this issue May 18, 2017 · 0 comments

Assignees

Labels

feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/redux-component release-notes/exclude

Milestone

0.17.13 (Release ...

Contributor

NejcZdovc commented May 18, 2017 •

edited by luixxiul

Loading

Test plan

https://github.com/brave/browser-laptop/wiki/Manual-Tests#bookmarks

Test that creating a bookmark on the bookmarks toolbar with the star button works
Test that creating a bookmark on the bookmarks toolbar by dragging the un/lock icon works
Test that creating a bookmark folder on the bookmarks toolbar works
Test that moving a bookmark into a folder by drag and drop on the bookmarks folder works
Test that clicking a bookmark in the toolbar loads the bookmark.
Test that clicking a bookmark in a bookmark toolbar folder loads the bookmark.

Describe the issue you encountered:
Refactor addEditBookmark and addEditBookmarkHanger to redux.

The text was updated successfully, but these errors were encountered:

NejcZdovc added the refactoring/redux-component label

NejcZdovc added this to the 0.15.400 milestone

NejcZdovc self-assigned this

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Refactors addEditBookmarHanger and addEditBookmark to redux

ca78189

Resolves brave#8927

Auditors: @bsclifton

Test Plan:
- try to bookmark a page

NejcZdovc mentioned this issue

Refactors addEditBookmarkHanger and addEditBookmark into redux #8928

Merged

7 tasks

luixxiul added the feature/bookmarks label

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Refactors addEditBookmarHanger and addEditBookmark to redux

f1eb47d

Resolves brave#8927

Auditors: @bsclifton

Test Plan:
- try to bookmark a page

luixxiul added the QA/test-plan-specified label

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Refactors addEditBookmarHanger and addEditBookmark to redux

485d5b0

Resolves brave#8927

Auditors: @bsclifton

Test Plan:
- try to bookmark a page

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Refactors addEditBookmarHanger and addEditBookmark to redux

87dd8d9

Resolves brave#8927

Auditors: @bsclifton

Test Plan:
- try to bookmark a page

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Refactors addEditBookmarHanger and addEditBookmark to redux

29002c0

Resolves brave#8927

Auditors: @bsclifton

Test Plan:
- try to bookmark a page

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Refactors addEditBookmarHanger and addEditBookmark to redux

fcf89f1

Resolves brave#8927

Auditors: @bsclifton

Test Plan:
- try to bookmark a page

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Refactors addEditBookmarHanger and addEditBookmark to redux

cd35e14

Resolves brave#8927

Auditors: @bsclifton

Test Plan:
- try to bookmark a page

NejcZdovc closed this as completed in #8928

NejcZdovc added a commit that referenced this issue


          Refactors addEditBookmarHanger and addEditBookmark to redux

f34bdff

Resolves #8927

Auditors: @bsclifton

Test Plan:
- try to bookmark a page

luixxiul added the release-notes/exclude label

This was referenced Jun 19, 2017

Manual test run on Linux(Gnome) for 0.17.x #9573

Closed

Manual test run on Windows x64 for 0.17.x #9575

Closed

Manual test run on Windows ia-32 for 0.17.x #9576

Closed

Manual test run on OS X for 0.17.x #9577

Closed

luixxiul added the QA/checked-Linux label

srirambv added the QA/checked-Win64 label

Jacalz mentioned this issue

Manual test run for 0.17.x on Windows x64 #9636

Closed

94 tasks

LaurenWags added the QA/checked-macOS label

alexwykoff mentioned this issue

Manual test run on Windows ia-32 for 0.17.x RC2 #9662

Closed

LaurenWags mentioned this issue

Manual Test Run on Windows x32 for 0.17.x RC3 #9682

Closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.