Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Browser crashes when trying to login to GitHub #9138

Closed
srirambv opened this issue May 30, 2017 · 14 comments
Closed

Browser crashes when trying to login to GitHub #9138

srirambv opened this issue May 30, 2017 · 14 comments

Comments

@srirambv
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Browser crashes when trying to login to GitHub

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.16.0
    rev be76cd3
    Muon 3.2.101

  • Steps to reproduce:

    1. Clean install 0.16.0
    2. Open github.com/signin
    3. Enter User ID/Password and click signin browser crashes
  • Actual result:
    Browser crashes when trying to login to GitHub

  • Expected result:
    Should not crash

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:

    1. Having pinned tabs doesn't crash but only causes webview crash
  • Screenshot if needed:

  • Any related issues:

@srirambv srirambv added this to the 0.16.0 milestone May 30, 2017
@darkdh darkdh self-assigned this May 30, 2017
@srirambv
Copy link
Collaborator Author

Disabling password manager doesn't causes the crash when signing into GitHub.

@darkdh
Copy link
Member

darkdh commented May 30, 2017

hmm, I can't reproduce even with built-in password manager enabled

@darkdh darkdh removed their assignment May 30, 2017
@srirambv
Copy link
Collaborator Author

Unable to reproduce the issue after upgrade from 0.15.310 or clean install on 0.16.0. Closing the issue for now. Will reopen if I can get reliable STR.

Closing #9138

@srirambv
Copy link
Collaborator Author

srirambv commented Jun 9, 2017

Reopening the issue based on community thread https://community.brave.com/t/typing-password-makes-brave-crash/3702/

cc: @darkdh

@srirambv srirambv reopened this Jun 9, 2017
@bsclifton
Copy link
Member

possibly related: #9356

@alexwykoff
Copy link
Contributor

Closing this issue as all reports thus far have shown the crash to be gone.

@frk2
Copy link

frk2 commented Jun 11, 2017

I'm still experiencing this crash on Ubuntu 17.04 with brave 0.16.9 rev fba98fc. Let me know how I can help? Password manager or not 😕

@luixxiul
Copy link
Contributor

Re-opening just in case.

@luixxiul luixxiul reopened this Jun 12, 2017
@luixxiul luixxiul removed this from the 0.16.9 milestone Jun 12, 2017
@luixxiul luixxiul added needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. and removed release-notes/exclude labels Jun 12, 2017
@alexwykoff
Copy link
Contributor

It seems as though another Linux user is experiencing login issues as well : https://community.brave.com/t/bug-report-login-crashes-brave/3947

@lundsted
Copy link

lundsted commented Jun 16, 2017

It seems as though another Linux user is experiencing login issues as well :

Linux user here, also experiencing this issue, fx with Facebook. Happens after 8 characters typed into the password field.

@darkdh darkdh self-assigned this Jun 16, 2017
@frk2
Copy link

frk2 commented Jun 21, 2017

Seems like this is such is now fixed with the latest update!

@bsclifton
Copy link
Member

bsclifton commented Jun 21, 2017

@frk2 that is correct- we have fixed this with our latest release 😄 (0.16.12). Menus on Gnome are still broken (we're working on a hot-fix for that)

The root cause was: 0.16.9 shipped with Muon version 4.0.2 instead of 4.0.3 because of a build problem (the fix for login happened in 4.0.3).

Closing as this issue is now resolved

@bsclifton bsclifton removed the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Jun 21, 2017
@luixxiul luixxiul modified the milestones: 0.16.9, 0.17.x (Beta Channel) Jun 21, 2017
@luixxiul
Copy link
Contributor

@srirambv @LaurenWags @alexwykoff please test the issue was fixed.

@bsclifton
Copy link
Member

bsclifton commented Jun 21, 2017

@luixxiul I'm going to assign a more appropriate milestone as we'll have a Linux release soon (it can be tested with 0.17.x also, but we'll be pushing a 0.16.x hot-fix before that)

@bsclifton bsclifton modified the milestones: 0.16.x menu hotfix, 0.17.x (Beta Channel) Jun 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants