Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Unable to fire devTools via shortcut #9889

Closed
cezaraugusto opened this issue Jul 6, 2017 · 1 comment
Closed

Unable to fire devTools via shortcut #9889

cezaraugusto opened this issue Jul 6, 2017 · 1 comment
Assignees
@NejcZdovc
Labels
feature/developer-tools QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@cezaraugusto
Copy link
Contributor

STR:

  1. open any website
  2. Right click, inspect element
  3. Works fine
  4. Close devtools
  5. Try cmd+option+i on mac
  6. doesn't work

Issue happens due to state passed down to tabState.getActiveTab() which includes an empty list, so the result who is looking for the active tab returns undefined.

Err log (following STR will lead you here):

An uncaught exception occurred in the main process Uncaught Exception:
TypeError: Cannot read property 'get' of undefined
    at click (/Users/cezaraugusto/dev/browser-laptop/app/browser/menu.js:273:44)

seems related to 735037e#diff-e39b9756f3113b75562a5aa516c1a31cR269. Labeling to 0.19.x to match the change.

@NejcZdovc mind taking a look at this one?
@cezaraugusto cezaraugusto added this to the 0.19.x (Developer Channel) milestone Jul 6, 2017
@NejcZdovc NejcZdovc self-assigned this Jul 6, 2017
@NejcZdovc
Copy link
Contributor

Thanks for creating issue for it. I notice this as well, but didn't have time to create an issue for it.

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 7, 2017
@NejcZdovc
Fixes dev tools
21bb33a 
Resovles brave#9889

Auditors: @cezaraugusto

Test Plan:
- open one page
- go to view menu
- click on dev tools
@NejcZdovc NejcZdovc mentioned this issue Jul 7, 2017
Merged
8 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jul 7, 2017
@NejcZdovc
Fixes dev tools
1d3230a 
Resolves brave#9889

Auditors: @cezaraugusto

Test Plan:
- open one page
- go to view menu
- click on dev tools
cezaraugusto added a commit that referenced this issue Jul 8, 2017
@cezaraugusto
Merge pull request #9897 from NejcZdovc/hotfix/#9889-devtools
dc76f0a 
Fixes inspect element option when used by shortcut
cezaraugusto added a commit that referenced this issue Jul 8, 2017
@cezaraugusto
Merge pull request #9897 from NejcZdovc/hotfix/#9889-devtools
7efb0d0 
Fixes inspect element option when used by shortcut
This was referenced Sep 20, 2017
Closed
Closed
Closed
Closed
This was referenced Sep 20, 2017
Closed
Closed
This was referenced Sep 21, 2017
Closed
Closed
This was referenced Sep 25, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Sep 27, 2017
Closed
@srirambv srirambv mentioned this issue Sep 28, 2017
Closed
@srirambv srirambv mentioned this issue Oct 9, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/developer-tools QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
5 participants
@luixxiul @cezaraugusto @NejcZdovc @srirambv @LaurenWags