Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix lint errors introduced with #9879 #10128

Closed
wants to merge 1 commit into from
Closed

Fix lint errors introduced with #9879 #10128

wants to merge 1 commit into from

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jul 25, 2017

#9879

See b794367#diff-8a9bac13ef6264feb2b6da7c18d86b3cR233

Auditors:

Test Plan: npm run lint

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@luixxiul luixxiul requested a review from darkdh July 25, 2017 17:40
@luixxiul luixxiul added this to the 0.19.x (Developer Channel) milestone Jul 25, 2017
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++. Thanks

@codecov-io
Copy link

codecov-io commented Jul 25, 2017

Codecov Report

Merging #10128 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #10128   +/-   ##
=======================================
  Coverage    52.8%    52.8%           
=======================================
  Files         227      227           
  Lines       20197    20197           
  Branches     3234     3234           
=======================================
  Hits        10666    10666           
  Misses       9531     9531
Flag Coverage Δ
#unittest 52.8% <100%> (ø) ⬆️
Impacted Files Coverage Δ
app/filtering.js 18.33% <100%> (ø) ⬆️

@bsclifton
Copy link
Member

Apologies- I didn't see this and fixed with d14fb50 ☹️

@bsclifton bsclifton closed this Jul 25, 2017
@bsclifton bsclifton removed this from the 0.19.x (Developer Channel) milestone Jul 25, 2017
@luixxiul luixxiul deleted the fix-lint branch July 26, 2017 04:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants