Update enabledContent.js to BEM style #10147
Conversation
luixxiul
added
the
polish
|
note: I will squash the commits in one commit after review is done. |
|
|
| marginTop: '15px', | ||
| lineHeight: 1.5 | ||
| }, | ||
|
|
||
| settingsListContainer: { |
There was a problem hiding this comment.
settingsListContainer is not added to any elements so this can be removed.
Codecov Report
@@ Coverage Diff @@
## master #10147 +/- ##
=======================================
Coverage 52.93% 52.93%
=======================================
Files 228 228
Lines 20297 20297
Branches 3252 3252
=======================================
Hits 10744 10744
Misses 9553 9553
|
| @@ -3,7 +3,7 @@ | |||
| * You can obtain one at http://mozilla.org/MPL/2.0/. */ | |||
|
|
|||
| const React = require('react') | |||
| const {StyleSheet, css} = require('aphrodite') | |||
| const {StyleSheet, css} = require('aphrodite/no-important') | |||
| textDecoration: 'none', | ||
|
|
||
| ':hover': { | ||
| textDecoration: 'none' | ||
| } | ||
| }, | ||
|
|
||
| iconText: { | ||
| balance__iconLink__iconText: { | ||
| color: globalStyles.color.mediumGray, | ||
| margin: '0 0 0 5px', | ||
|
|
There was a problem hiding this comment.
below we have:
// TODO: refactor preferences.less to remove !important
fontSize: `${globalStyles.fontSize.settingItemSubtext} !important
is that still needed?
There was a problem hiding this comment.
Actually paymentStyles.font.regular should be replaced with globalStyles.fontSize.settingItemSubtext as there is no reason why font-size on the payments tab is different than the other tabs.
|
The regression was fixed with 72c9fc1. |
Closes #10146 Also: - aphrodite -> aphrodite/no-important
|
The commits were squashed and the PR is ready to be merged. |
|
I'm restructuring |
|
Opened: #10238 |
Closes #10146
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests