Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Align paymentsMessage and paymentsSidebar with flex instead of float #10154

Merged
merged 1 commit into from
Aug 1, 2017
Merged

Align paymentsMessage and paymentsSidebar with flex instead of float #10154

merged 1 commit into from
Aug 1, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jul 26, 2017

Fixes #10153

Auditors: @cezaraugusto

Test Plan:

  1. Open about:preferences#payments
  2. Enable and disable Payments
  3. Make sure that the margin between the title wrapper and the content does not change

margin

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fixes #10153

Auditors: @cezaraugusto

Test Plan:
1. Open about:preferences#payments
2. Enable and disable Payments
3. Make sure that the margin between the title wrapper and the content does not change
@luixxiul luixxiul added feature/about-pages polish Nice to have — usually related to front-end/visual tasks. labels Jul 26, 2017
@luixxiul luixxiul added this to the 0.20.x (Nightly Channel) milestone Jul 26, 2017
@luixxiul luixxiul self-assigned this Jul 26, 2017
@luixxiul luixxiul requested a review from cezaraugusto July 26, 2017 12:54
@codecov-io
Copy link

codecov-io commented Jul 26, 2017

Codecov Report

Merging #10154 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #10154   +/-   ##
=======================================
  Coverage   52.81%   52.81%           
=======================================
  Files         227      227           
  Lines       20195    20195           
  Branches     3234     3234           
=======================================
  Hits        10665    10665           
  Misses       9530     9530
Flag Coverage Δ
#unittest 52.81% <100%> (ø) ⬆️
Impacted Files Coverage Δ
.../components/preferences/payment/disabledContent.js 100% <100%> (ø) ⬆️

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better! such flexbox very amazing ++

@cezaraugusto cezaraugusto modified the milestones: 0.21.x (Nightly Channel), 0.20.x (Developer Channel) Aug 1, 2017
@cezaraugusto cezaraugusto merged commit 117d8e3 into brave:master Aug 1, 2017
@luixxiul luixxiul deleted the fix-payments-margin branch August 1, 2017 02:52
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/about-pages polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants