Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix findbar slowness #10283

Merged
merged 1 commit into from
Aug 4, 2017
Merged

Fix findbar slowness #10283

merged 1 commit into from
Aug 4, 2017

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Aug 3, 2017

FIxes #10271

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

  • Find on page should work as before
  • Loading a large page and finding (while it's loading) shouldn't cause lag (eg: typing shows up immediately)

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@bsclifton bsclifton requested a review from NejcZdovc August 3, 2017 21:57
@bsclifton bsclifton self-assigned this Aug 3, 2017
@bsclifton bsclifton modified the milestones: 0.18.x Hotfix, 0.20.x (Developer Channel) Aug 3, 2017
@bsclifton bsclifton changed the base branch from master to fix/sync-for-sites-refactor August 3, 2017 22:02
@diracdeltas
Copy link
Member

i think this needs a rebase

@bsclifton bsclifton changed the base branch from fix/sync-for-sites-refactor to refactor/sites-split August 3, 2017 22:03
@bsclifton bsclifton changed the base branch from refactor/sites-split to master August 3, 2017 22:05
@bsclifton bsclifton modified the milestones: 0.18.x Hotfix, 0.20.x (Developer Channel) Aug 3, 2017
@bsclifton bsclifton changed the title Fix find bar slowness Fix findbar slowness Aug 3, 2017
@codecov-io
Copy link

codecov-io commented Aug 3, 2017

Codecov Report

Merging #10283 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10283      +/-   ##
==========================================
- Coverage   52.95%   52.93%   -0.02%     
==========================================
  Files         228      228              
  Lines       20308    20308              
  Branches     3253     3253              
==========================================
- Hits        10754    10751       -3     
- Misses       9554     9557       +3
Flag Coverage Δ
#unittest 52.93% <ø> (-0.02%) ⬇️
Impacted Files Coverage Δ
js/stores/appStoreRenderer.js 91.17% <0%> (-8.83%) ⬇️

@bsclifton bsclifton requested a review from bbondy August 4, 2017 04:21
@bbondy bbondy merged commit 75ec0d6 into brave:master Aug 4, 2017
bbondy added a commit that referenced this pull request Aug 4, 2017
bbondy added a commit that referenced this pull request Aug 4, 2017
bsclifton added a commit that referenced this pull request Aug 4, 2017
@luixxiul luixxiul added the perf label Aug 4, 2017
@bsclifton bsclifton deleted the fix-find-bar branch August 30, 2017 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants