This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
rely on compositor properties for tab previews #10293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auditors: @bsclifton, @luixxiul close #10291
bsclifton
approved these changes
Aug 4, 2017
bsclifton
added a commit
that referenced
this pull request
Aug 4, 2017
rely on compositor properties for tab previews
bsclifton
added a commit
that referenced
this pull request
Aug 4, 2017
rely on compositor properties for tab previews
bsclifton
added a commit
that referenced
this pull request
Aug 4, 2017
rely on compositor properties for tab previews
luixxiul
reviewed
Aug 4, 2017
| @@ -83,6 +83,7 @@ html, | |||
| height: 100%; | |||
| width: 100%; | |||
| &.isPreview { | |||
| will-change: opacity; | |||
There was a problem hiding this comment.
nice find! There could be more elements which can be optimized with will-change.
There was a problem hiding this comment.
yes the browser reserves a chunk of memory for that so they're costly if done several times but new tab load and tab's loading animation can benefit too. lmk if you know some other areas. it applies for opacity and transform properties.
This was referenced Aug 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auditors: @bsclifton, @luixxiul
close #10291
before checking out this PR
check out this PR and repeat above operation.
numbers should be lower
before
after
