-
Notifications
You must be signed in to change notification settings - Fork 975
Fix URL parsing consistency issue #10346
Conversation
Fix #10270 by preferring muon.url.parse over Node's legacy (and non-standards compliant) URL parser. This is subobtimal because unit tests are running a different URL parser from the actual browser, but seems like the best trade off for now. Test Plan: 1. go to brave.com and disable shields 2. go to http://brave.com%60x.code-fu.org/. shields should not be disabled.
Fix URL parsing consistency issue
Fix URL parsing consistency issue
Fix URL parsing consistency issue
The lion head should not be disabled? |
@srirambv right |
CC @diracdeltas I'm not sure if this is fixed. The lion icon is orange, while the toggle is disabled. Brave: 0.18.22 |
@luixxiul did you start with a clean session store? seems to work for me on 0.18.x |
Works as per str. But I still see the shields show as brave.com as per @luixxiul screenshot above. |
maybe I have turned off the shield on brave.com. Let me check again. |
I think it works as expected, if I visit http://brave.com%60x.code-fu.org/ in a new tab, shields is disabled by default, so shields showing brave.com sounds correct to me. |
Fix #10270 by preferring muon.url.parse over Node's legacy (and non-standards compliant) URL parser. This is subobtimal because unit tests are running a different URL parser from the actual browser, but seems like the best trade off for now.
Also fixes #6098
Test Plan:
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests