Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Convert helpfulText with Aphrodite #10609

Merged
merged 1 commit into from
Sep 5, 2017
Merged

Convert helpfulText with Aphrodite #10609

merged 1 commit into from
Sep 5, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Aug 21, 2017

Closes #10608

Auditors:

Test Plan:

  1. Open about:preferences#extensions
  2. Make sure the help text is rendered

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Closes #10608

Auditors:

Test Plan:
1. Open `about:preferences#extensions`
2. Make sure the help text is rendered
@luixxiul luixxiul self-assigned this Aug 21, 2017
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 21, 2017
@codecov-io
Copy link

codecov-io commented Aug 21, 2017

Codecov Report

Merging #10609 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #10609      +/-   ##
==========================================
+ Coverage   54.19%    54.2%   +0.01%     
==========================================
  Files         244      244              
  Lines       21109    21114       +5     
  Branches     3258     3258              
==========================================
+ Hits        11440    11445       +5     
  Misses       9669     9669
Flag Coverage Δ
#unittest 54.2% <100%> (+0.01%) ⬆️
Impacted Files Coverage Δ
...p/renderer/components/preferences/extensionsTab.js 89.65% <ø> (ø) ⬆️
app/renderer/components/preferences/helpfulText.js 100% <100%> (ø) ⬆️

@luixxiul luixxiul requested a review from cezaraugusto August 28, 2017 01:50
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit ab262b8 into brave:master Sep 5, 2017
@cezaraugusto cezaraugusto deleted the helpfulText-aphrodite branch September 5, 2017 01:13
@bbondy bbondy removed this from the 0.21.x (Developer Channel) milestone Oct 25, 2017
@luixxiul luixxiul added this to the 0.20.x (Beta Channel) milestone Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants