This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Align the first button on error pages #10680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #10679 Auditors: @cezaraugusto Test Plan: 1. Open https://expired.badssl.com/ 2. Make sure the first button is aligned to the left
luixxiul
commented
Aug 28, 2017
| @@ -23,11 +23,8 @@ | |||
| .buttons { | |||
| display: flex; | |||
| flex-flow: row wrap; | |||
| position: relative; | |||
| right: .2em; // cancel margin: .2em to align .buttons and .certErrorText | |||
There was a problem hiding this comment.
See: 98217b3#diff-85bb393e13c9679fa6b5d5ea691bfdeaR27
We don't need those as the button does not have margin by default (unless tagged with groupedItem)
cezaraugusto
added a commit
that referenced
this pull request
Sep 5, 2017
Align the first button on error pages
cezaraugusto
added a commit
that referenced
this pull request
Sep 5, 2017
Align the first button on error pages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10679
Auditors: @cezaraugusto
Test Plan:
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests
Setting the milestone to 0.19 as the regression has been introduced with 3dfc598#diff-0ff973318abdc5c07f55cefe86bd5ed7R109.