Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed ledger state update #11000

Closed
wants to merge 1 commit into from
Closed

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Sep 18, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Resolves #9641

Auditors:

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Resolves brave#9641

Auditors:

Test Plan:
@NejcZdovc NejcZdovc added this to the 0.21.x (Nightly Channel) milestone Sep 18, 2017
@NejcZdovc NejcZdovc self-assigned this Sep 18, 2017
@codecov-io
Copy link

codecov-io commented Sep 18, 2017

Codecov Report

Merging #11000 into master will increase coverage by 0.19%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #11000      +/-   ##
==========================================
+ Coverage   54.24%   54.43%   +0.19%     
==========================================
  Files         249      249              
  Lines       21836    21755      -81     
  Branches     3399     3378      -21     
==========================================
- Hits        11844    11843       -1     
+ Misses       9992     9912      -80
Flag Coverage Δ
#unittest 54.43% <0%> (+0.19%) ⬆️
Impacted Files Coverage Δ
js/stores/appStore.js 15.54% <0%> (+2.03%) ⬆️

@ghost ghost added sprint/1 and removed sprint/1 labels Sep 18, 2017
@NejcZdovc NejcZdovc mentioned this pull request Sep 19, 2017
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Nightly Channel), 0.19.x (Beta Channel) Sep 19, 2017
@NejcZdovc
Copy link
Contributor Author

closing in favour of #11009

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants