-
Notifications
You must be signed in to change notification settings - Fork 973
Add transition animation to tab width when returning to normal after mouse close #11438
Add transition animation to tab width when returning to normal after mouse close #11438
Conversation
…a mouseover tab close button followed by a mouseout Fix brave#7001
b086446
to
4a9221b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicely done, animation seemed a bit slow for me but definitely not a blocker and up to design-team the final decision, looks great from engineering side and this looks/feels super cool so merging ++
@petemill @cezaraugusto Is this issue related with this PR? The tab overflows instantly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried it out- this looks and feels great 😄 👍 Well done!
@luixxiul do you have repro steps for that? I'll check it out with these changes and before |
Here is a STR:
And the tab overflow issue above #11438 (comment) should be reproduced. |
Fix #7001
note that this functionality will appear broken, as it does without the animation in master currently, due to a bug which is fixed by #11436.Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan (manual):
flex tabs
Max-width tabs
Reviewer Checklist:
Tests