Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add transition animation to tab width when returning to normal after mouse close #11438

Merged
merged 1 commit into from
Oct 14, 2017

Conversation

petemill
Copy link
Member

@petemill petemill commented Oct 11, 2017

Fix #7001

note that this functionality will appear broken, as it does without the animation in master currently, due to a bug which is fixed by #11436.

59ddd21894f7a209624579

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan (manual):

flex tabs

  • Make the window narrow
  • Open ~7 tabs (enough for the tabs to fill the width of the container and get smaller)
  • Mouse over the first tab's close button and click it
  • Close another couple tabs (optional)
  • Mouse away from the tabs bar
  • Observe animation of tabs back to normal size

Max-width tabs

  • Make the window wider
  • Open ~3 tabs (not enough for the tabs to fill the width of the container and get smaller)
  • Mouse over the first tab's close button and click it
  • mouse away from the tabs bar
  • Observe there is no animation of tabs back to normal size, since they did not change size

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@petemill petemill added design A design change, especially one which needs input from the design team. feature/tabsbar labels Oct 11, 2017
@petemill petemill self-assigned this Oct 11, 2017
…a mouseover tab close button followed by a mouseout

Fix brave#7001
@petemill petemill force-pushed the tab-animate-width-postclose branch from b086446 to 4a9221b Compare October 13, 2017 21:16
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done, animation seemed a bit slow for me but definitely not a blocker and up to design-team the final decision, looks great from engineering side and this looks/feels super cool so merging ++

@cezaraugusto cezaraugusto added this to the 0.22.x (Nightly Channel) milestone Oct 14, 2017
@cezaraugusto cezaraugusto merged commit fc95fd5 into brave:master Oct 14, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Oct 14, 2017

@petemill @cezaraugusto Is this issue related with this PR? The tab overflows instantly.

tabs

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried it out- this looks and feels great 😄 👍 Well done!

@petemill petemill deleted the tab-animate-width-postclose branch October 16, 2017 21:34
@petemill
Copy link
Member Author

@luixxiul do you have repro steps for that? I'll check it out with these changes and before

@luixxiul
Copy link
Contributor

Here is a STR:

  1. git fetch upstream master && git rebase upstream/master (ie I am not quite sure if this PR is the cause of the issue)
  2. npm run watch
  3. npm start
  4. Open 10 tabs (until the tab size changes)
  5. Click the close button on a tab
  6. Move the mouse cursor from the tabs bar

And the tab overflow issue above #11438 (comment) should be reproduced.

@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/tabsbar release-notes/include
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab size change should have transition animation
5 participants