This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Redo exception to cover Chrome's case #11647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #11401 AGAIN Auditors: @bbondy Test Plan: 1. Clean cookies on Chrome/Firefox and login in google account 2. Import cookies from Chrome/Firefox to Brave 3. Login google account on Brave 4. Import cookies from Chrome/Firefox to Brave and refresh 5. Logout google account on Brave 6. There shouldn't be any cookie mismatch error pages displayed within these steps
bbondy
approved these changes
Oct 24, 2017
bbondy
approved these changes
Oct 24, 2017
bbondy
approved these changes
Oct 24, 2017
Codecov Report
@@ Coverage Diff @@
## master #11647 +/- ##
=======================================
Coverage 52.33% 52.33%
=======================================
Files 269 269
Lines 25377 25377
Branches 4042 4042
=======================================
Hits 13281 13281
Misses 12096 12096
|
darkdh
added a commit
that referenced
this pull request
Oct 24, 2017
Redo exception to cover Chrome's case
darkdh
added a commit
that referenced
this pull request
Oct 24, 2017
Redo exception to cover Chrome's case
darkdh
added a commit
that referenced
this pull request
Oct 24, 2017
Redo exception to cover Chrome's case
darkdh
added a commit
that referenced
this pull request
Dec 4, 2017
fix #11401 Auditors: @bsclifton, @bbondy Test Plan: 1. #11401 (comment) 2. #11647 (comment) 3. #11401 (comment) 4. 4.a Clear cookies on FF and Chrome, login to gmail account 1 and account 2 4.b Close FF and Chrome, Open Brave (clean profile) 4.c Import cookies only from FF and Chrome 4.d Navigate to mail.google.com --> you have to enter password for account 1 and account 2 (but no 2FA) 4.e Import cookies from FF and Chrome again, refresh gmail page (you will have to enter password again to login both accounts) 4.f Logout and you will see login page with both accounts loggout (no cookie mismatch error) 5. unit test
8 tasks
bsclifton
pushed a commit
that referenced
this pull request
Feb 8, 2018
fix #11401 Auditors: @bsclifton, @bbondy Test Plan: 1. #11401 (comment) 2. #11647 (comment) 3. #11401 (comment) 4. 4.a Clear cookies on FF and Chrome, login to gmail account 1 and account 2 4.b Close FF and Chrome, Open Brave (clean profile) 4.c Import cookies only from FF and Chrome 4.d Navigate to mail.google.com --> you have to enter password for account 1 and account 2 (but no 2FA) 4.e Import cookies from FF and Chrome again, refresh gmail page (you will have to enter password again to login both accounts) 4.f Logout and you will see login page with both accounts loggout (no cookie mismatch error) 5. unit test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #11401 AGAIN
Auditors: @bbondy
Test Plan:
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests