This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fixes undefined scenarios #11804
Merged
Fixes undefined scenarios #11804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11804 +/- ##
==========================================
- Coverage 52.61% 52.61% -0.01%
==========================================
Files 271 271
Lines 25715 25714 -1
Branches 4104 4105 +1
==========================================
- Hits 13530 13529 -1
Misses 12185 12185
|
cezaraugusto
reviewed
Nov 6, 2017
app/browser/api/ledger.js
Outdated
| @@ -2445,6 +2444,11 @@ const transitionWalletToBat = () => { | |||
| return | |||
| } | |||
|
|
|||
| if (!client) { | |||
| console.log('client error') | |||
There was a problem hiding this comment.
is this intentional? could be a console.error if so
There was a problem hiding this comment.
Yes it's intentional. Because this is not really an error, it's just log that there was a race condition and it will be re-triggered after another call
Resolves brave#11703 Resolves brave#11684 Auditors: Test Plan:
NejcZdovc
force-pushed
the
hotfix/#11703-typeError
branch
from
bd4e483
to
3255d9c
Compare
bsclifton
approved these changes
Nov 7, 2017
bbondy
modified the milestones:
0.19.x Hotfix 5 (Release channel),
0.19.x Hotfix 4 (Release channel)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -ito squash commits (if needed).Resolves #11703
Resolves #11684
Auditors:
Test Plan:
Reviewer Checklist:
Tests